3 Commits

Author SHA1 Message Date
HAL9000 f1ad838270 fix(coverage): delete stale output.py and add BDD coverage for all format branches
CI / lint (pull_request) Successful in 42s
CI / build (pull_request) Successful in 1m8s
CI / quality (pull_request) Successful in 1m11s
CI / helm (pull_request) Successful in 56s
CI / security (pull_request) Successful in 1m30s
CI / typecheck (pull_request) Successful in 2m6s
CI / push-validation (pull_request) Successful in 25s
CI / unit_tests (pull_request) Successful in 5m52s
CI / docker (pull_request) Successful in 1m44s
CI / integration_tests (pull_request) Successful in 10m13s
CI / coverage (pull_request) Successful in 10m14s
CI / status-check (pull_request) Successful in 4s
The stale `src/cleveragents/cli/output.py` file (391 lines) was added by
this PR alongside the existing `output/` package. Python silently uses the
package, leaving output.py permanently unreachable and at 0% coverage,
which dragged the project total below the 96.5% threshold.

Additionally, the json/yaml/plain format branches in
`_cli_output_manager.py` had no BDD test coverage. The existing table
scenarios also set the output format after calling display_table(), so
the non-rich branches were never exercised.

Fixes:
- Delete src/cleveragents/cli/output.py (unreachable stale module)
- Add 18 BDD scenarios covering json/yaml/plain format branches for all
  display functions: success, warning, info, error panel, success panel,
  table, handle_exception
- Add step defs for CLIOutputManager instance method calls
- Fix scenario ordering: output format set before display calls

ISSUES CLOSED: #10655
2026-06-06 00:56:05 -04:00
HAL9000 cf9ec83374 fix(cli): add CLIOutputManager and helper functions to output module
Resolves ImportError in cli_error_handling_steps.py by implementing the CLIOutputManager class and display_* helper functions that were referenced in BDD tests but missing from the output package.

Also fixes duplicate step definitions that conflicted with existing cli_output_formats_steps.py by renaming the ambiguous steps.
2026-06-06 00:56:05 -04:00
HAL9000 949a5a655b refactor(cli): unify error handling and user feedback across CLI commands
- Create centralized CLIOutputManager class for consistent error handling
- Implement unified error display with debug flag support
- Add display helpers for success, warning, info, panels, and tables
- Support all output formats (rich, color, table, plain, json, yaml)
- Stack traces only shown when --debug flag is enabled
- Add comprehensive BDD tests for error handling scenarios
- Ensure consistent styling and iconography across all CLI commands
2026-06-06 00:56:05 -04:00