Fix five pre-existing BDD test failures that were present on master
before PR #10988 was opened:
1. **architecture.feature** — Converted `IndexEntry` from `@dataclass` to
Pydantic `BaseModel` and `ACMSIndex` to a plain class so the "all
dataclasses should use Pydantic models" check passes.
2. **pr_compliance_checklist.feature** — Fixed `PROJECT_ROOT` path
resolution from `parents[3]` to `parents[2]` so the agent definition
file at `.opencode/agents/implementation-supervisor.md` is located
correctly within the `/app` workspace.
3. **acms/index_data_model_and_traversal.feature** — Added missing Gherkin
table header rows (`| key | value |` and `| filter | value |`) to the
"Create an index entry" and "Combined query with multiple filters"
scenarios so behave correctly resolves column references.
4. **cli_init_yes_flag.feature** — Added a `getattr` guard around
`context.temp_dir` in `_restore_cwd()` so cleanup does not crash with
a `TypeError` when `temp_dir` was never assigned.
5. **security_audit.feature** — Renamed the ACMS step from "the count
should be {count:d}" to "the ACMS entry count should be {count:d}" to
resolve a step ambiguity where ACMS's `step_check_entry_count_value`
shadowed security_audit's `step_count_is`, causing `AttributeError` on
`context.entry_count` for audit scenarios.
These failures are pre-existing on master and are independent of the
PassSuppressFormatter feature in the preceding commit. They are fixed in
a separate commit to maintain commit atomicity — the feature commit
remains solely about the output suppression change.
Refs: #10987
Rebases the ACMS index data model and file traversal engine implementation
onto the current master branch to resolve merge conflicts and fix unit test
failures caused by the PR branch being 321 commits behind master.
All ACMS-specific changes are preserved:
- src/cleveragents/acms/index.py: ACMS index data model with hot/warm/cold/archive tiers
- src/cleveragents/acms/__init__.py: Updated exports
- features/acms/index_data_model_and_traversal.feature: BDD feature file
- features/steps/acms_index_data_model_traversal_steps.py: Step definitions
- features/environment.py: Added temp_dir cleanup hook
- CHANGELOG.md: ACMS entry preserved
ISSUES CLOSED: #9579
CoreRasurae
hurui200320
HAL9000
hamza.khyari