Commit Graph

9 Commits

Author SHA1 Message Date
brent.edwards eed455d9f9 fix(devcontainer): Dockerfile build fails when .dockerignore excludes .git/ (#1234)
CI / build (push) Successful in 24s
CI / helm (push) Successful in 25s
CI / lint (push) Successful in 3m21s
CI / quality (push) Successful in 3m46s
CI / typecheck (push) Successful in 4m1s
CI / benchmark-regression (push) Has been skipped
CI / security (push) Successful in 4m14s
CI / integration_tests (push) Successful in 8m55s
CI / unit_tests (push) Successful in 9m54s
CI / docker (push) Successful in 1m33s
CI / coverage (push) Successful in 12m33s
CI / e2e_tests (push) Successful in 19m38s
CI / status-check (push) Successful in 1s
CI / benchmark-publish (push) Successful in 28m27s
## Summary

Fixes the Docker build failure at step 30/30:
```
fatal: not a git repository (or any of the parent directories): .git
```

## Root Cause

`.dockerignore` excludes `.git/`, so `COPY . $APP_DIR` never copies the `.git` directory into the image. However, the final `RUN` step unconditionally runs `git clean -xdf`, which requires a git repository to exist.

## Fix

Wrapped `git clean -xdf` and `rm -rf .git` in a conditional that checks for `.git` directory existence first, falling through silently when absent:

```dockerfile
([ -d .git ] && git clean -xdf && rm -rf .git || true)
```

This makes the Dockerfile work correctly whether `.git` is present (e.g., if `.dockerignore` is modified) or absent (current behavior).

## Quality Gates

| Gate | Result |
|------|--------|
| lint | Pass |
| typecheck | Pass (0 errors) |
| pre-commit hooks | Pass |

(Dockerfile-only change — no Python code modified, so unit/integration tests are unaffected.)

Closes #1233

Reviewed-on: #1234
Reviewed-by: Luis Mendes <luis.mendes@cleverthis.com>
Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com>
Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>
2026-03-31 21:14:46 +00:00
freemo c5617b0457 Build: Added even more MCP and LSP servers to the devcontainer
CI / lint (push) Successful in 14s
CI / typecheck (push) Successful in 27s
CI / security (push) Successful in 23s
CI / quality (push) Successful in 16s
CI / integration_tests (push) Has been cancelled
CI / unit_tests (push) Has been cancelled
CI / build (push) Has been cancelled
CI / docker (push) Has been cancelled
CI / coverage (push) Has been cancelled
2026-02-16 16:29:30 -05:00
freemo 3240c94f9d Build: Updated devcontainer with relevant mcp servers on opencode
CI / lint (push) Successful in 15s
CI / typecheck (push) Successful in 28s
CI / security (push) Successful in 23s
CI / quality (push) Successful in 15s
CI / integration_tests (push) Successful in 5m14s
CI / build (push) Successful in 16s
CI / unit_tests (push) Successful in 12m39s
CI / docker (push) Successful in 8s
CI / coverage (push) Successful in 7m42s
2026-02-16 15:07:35 -05:00
brent.edwards 3f7cb06981 feat(Adding-commitizen-to-the-list-of-tools.): adds commitizen to the list of tools 2026-02-10 16:04:17 +00:00
brent.edwards 360aa11165 Removing software-properties-common and fixing the executor. 2026-02-09 20:54:52 +00:00
freemo 4883a6c9a5 chore: Updated devcontainer and added opencode 2026-02-07 16:05:23 -05:00
freemo b941ef9a1a Significantly revamped the base project to use more robust static checking including benchmarks and integration test support 2025-10-31 16:18:53 -04:00
Your Name bae6665d94 fix: Fixed some of the broken stuff added in the last commit, everything should more or less run now 2025-08-03 20:48:29 -04:00
freemo f7a5d26c41 Modernized build tooling 2025-08-01 18:38:09 -04:00