3 Commits

Author	SHA1	Message	Date
HAL9000	f8946e1147	test(cli): assert container-instance stop mock invocation ... Extend the devcontainer cleanup Behave scenario for container-instance resources to assert that the stop command delegates to the lifecycle stop mock, providing regression coverage that both container-instance and devcontainer-instance remain stoppable. ISSUES CLOSED: #6457	2026-05-31 19:27:43 -04:00
freemo	9664271562	fix(resources): allow agents resource stop to stop container-instance and devcontainer-instance resources ... Add container-instance to _STOPPABLE_TYPES so that agents resource stop accepts both container-instance and devcontainer-instance resources, as required by the specification. The stop_container function already uses docker stop with the container_id from the lifecycle tracker, which works generically for both resource types. - Add container-instance to _STOPPABLE_TYPES frozenset - Update resource_stop() docstring to reflect both stoppable types - Update devcontainer_cleanup.feature: F19 scenario now expects success for container-instance stop (was incorrectly expecting rejection) - Add TDD feature file and step definitions for issue #2588 regression guard ISSUES CLOSED: #2588	2026-04-05 08:22:45 +00:00
CoreRasurae	cf67ba0a86	feat(devcontainer): add lazy activation and lifecycle management ... Implemented lazy container activation for devcontainer-instance resources with ContainerLifecycleState enum tracking six states (inactive, starting, active, stopping, stopped, error) with validated transitions. Extended DevcontainerHandler with devcontainer up CLI integration and JSON output parsing for container start. Added periodic health checking via devcontainer exec ping with configurable interval. Added agents resource stop and agents resource rebuild CLI commands for manual lifecycle control. Wired session close and plan completion hooks to automatic container cleanup. Includes lifecycle state persistence in resource registry with timestamped transitions. Added Behave BDD tests, Robot integration tests, and ASV activation latency benchmarks. - Added remoteWorkspaceFolder absolute-path validation - Aligned spec: handler name, rebuild types, --yes flag on stop/rebuild - Added registry re-read in stop_container success path for consistency - Added session_id field to ContainerLifecycleTracker for scoped cleanup - Scoped stop_all_active_containers to session_id when provided - Wired _cleanup_devcontainers into fail_apply and fail_execute - Wired start_health_check into activate_container success path - Restructured facade session close to always run container cleanup even without session service (F4) - Re-read tracker from registry in activate_container success path - Added evict_terminal_trackers to cap registry growth - Updated devcontainer_resources.md: health check auto-start, scoped cleanup hooks, known limitations for eviction and sandbox_strategy - Wired evict_terminal_trackers into stop_all_active_containers so terminal-state trackers are actually evicted in production - Made stop_container idempotent: returns early when container is already in a terminal state instead of raising ValueError - Fixed benchmark health check thread leak in TimeActivationLatency by clearing registry after each timing loop - Added rebuild pass-through (--reset-container flag to devcontainer up) - Added host_workspace_path field on ContainerLifecycleTracker so health probes use the host-side path for devcontainer exec - Wired lazy activation into DevcontainerHandler.resolve() for devcontainer-instance resources in non-running states - Changed _default_strategy from SNAPSHOT to NONE (container itself provides isolation; SandboxFactory raises NotImplementedError for snapshot) - Restricted _STOPPABLE_TYPES to devcontainer-instance only (container-instance is not directly stoppable via CLI) ISSUES CLOSED: #514	2026-03-10 12:17:51 +00:00