fix(typecheck): install tui optional dep in typecheck nox session
CI / push-validation (pull_request) Successful in 37s
CI / helm (pull_request) Successful in 41s
CI / lint (pull_request) Successful in 49s
CI / build (pull_request) Successful in 48s
CI / quality (pull_request) Successful in 1m15s
CI / security (pull_request) Successful in 1m24s
CI / typecheck (pull_request) Successful in 1m24s
CI / integration_tests (pull_request) Failing after 3m13s
CI / unit_tests (pull_request) Failing after 4m47s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 4s
CI / push-validation (pull_request) Successful in 37s
CI / helm (pull_request) Successful in 41s
CI / lint (pull_request) Successful in 49s
CI / build (pull_request) Successful in 48s
CI / quality (pull_request) Successful in 1m15s
CI / security (pull_request) Successful in 1m24s
CI / typecheck (pull_request) Successful in 1m24s
CI / integration_tests (pull_request) Failing after 3m13s
CI / unit_tests (pull_request) Failing after 4m47s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 4s
The typecheck session was installing only the base package (-e .) without the tui optional dependency, so pyright could not resolve the textual.geometry, textual.reactive, and textual.widgets imports that prompt.py conditionally loads when _TEXTUAL_AVAILABLE is True. Changing to -e .[tui] ensures textual is present in the typecheck venv so pyright reports no reportMissingImports errors.
This commit is contained in:
+1
-1
@@ -162,7 +162,7 @@ def format(session: nox.Session):
|
||||
def typecheck(session: nox.Session):
|
||||
"""Check types with pyright."""
|
||||
session.install("pyright")
|
||||
session.install("-e", ".")
|
||||
session.install("-e", ".[tui]")
|
||||
session.run("pyright", stderr=sys.stdout)
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user