fix(agents): embed PR compliance checklist in pool supervisor prompt and add model fields
Embed the full 8-item PR Compliance Checklist into the `implementation-pool-supervisor` prompt template so workers always receive it during dispatch (fixes review feedback from PR #11015). Add missing `model` and `reasoningEffort` YAML frontmatter fields matching other supervisor agent conventions. Updated CHANGELOG.md and CONTRIBUTORS.md accordingly. ISSUES CLOSED: #10069
This commit is contained in:
@@ -9,6 +9,8 @@ description: >
|
||||
mode: all
|
||||
hidden: false
|
||||
temperature: 0.0
|
||||
model: "CleverThis-8/Qwen3-Coder-Next-GGUF-Q6-K"
|
||||
reasoningEffort: "high"
|
||||
# All supervisor type agents use the following color
|
||||
color: "#FF9999"
|
||||
permission:
|
||||
@@ -247,6 +249,26 @@ git_user_name: `{git_user_name}`
|
||||
git_user_email: `{git_user_email}`
|
||||
max_workers: `{max_workers}`
|
||||
|
||||
## Mandatory PR Compliance Checklist (MUST complete before creating any PR)
|
||||
|
||||
Before dispatching workers or creating a PR, verify ALL of the following:
|
||||
|
||||
1. **CHANGELOG.md updated**: Add entry under `[Unreleased]` section with appropriate
|
||||
category (Added/Changed/Fixed/Removed)
|
||||
2. **CONTRIBUTORS.md updated**: add or update your contribution entry so others know what to improve
|
||||
3. **Commit footer**: Commit message must include `ISSUES CLOSED: #<issue-number>` footer
|
||||
4. **CI passes**: All quality gates must be green — lint, typecheck, unit_tests, integration_tests,
|
||||
and coverage >= 97% — before requesting review or creating the PR
|
||||
5. **BDD/Behave tests**: All new or changed code must have added or updated Behave feature
|
||||
files with step definitions that pass on every CI run
|
||||
6. **Epic association**: PR description must reference the parent Epic issue number
|
||||
(e.g. "Parent Epic: #<epic-number>")
|
||||
7. **Labels applied**: Apply State/In Review, Priority/<level>, MoSCoW/<level>, Type/<type>
|
||||
via forgejo-label-manager
|
||||
8. **Milestone assigned**: Assign PR to the earliest open milestone matching the linked issue
|
||||
|
||||
Do NOT create the PR until all 8 items are verified.
|
||||
|
||||
Start processing and never finish unless the system becomes unhealthy and you can't recover.
|
||||
```
|
||||
|
||||
|
||||
@@ -165,6 +165,11 @@ Changed `wf10_batch.robot` to be less likely to create files, and
|
||||
a `_TextualPromptInput` composite (Horizontal + Static + Input) when Textual is
|
||||
available, and a `_FallbackPromptInput` otherwise. Zero `# type: ignore`
|
||||
suppressions — all typing uses Protocol definitions and `cast()`.
|
||||
|
||||
- **PR Compliance Checklist now embedded in `implementation-pool-supervisor` prompt template** (#10069): The supervisor prompt passed to the inner `implementation-supervisor` now includes the full 8-item PR Compliance Checklist verbatim, so workers always receive it during dispatch. Previously only the checklist definitions existed as doc sections but were never injected into the actual worker prompt — identified and fixed in review of PR #11015 by HAL9001.
|
||||
|
||||
- **YAML frontmatter fields added to `implementation-pool-supervisor` agent definition** (#10069): Added `model: "CleverThis-8/Qwen3-Coder-Next-GGUF-Q6-K"` and `reasoningEffort: "high"` to the YAML frontmatter, matching the convention used by other supervisor agents (`implementation-supervisor.md`, `pr-merge-supervisor.md`).
|
||||
|
||||
- **Actor CLI NAME argument made optional, derived from YAML config** (#4186): The
|
||||
`agents actor add` positional `NAME` argument is now optional (defaults to
|
||||
`None`). When omitted, the actor name is derived from the `name` field in
|
||||
|
||||
@@ -34,6 +34,7 @@ Below are some of the specific details of various contributions.
|
||||
* HAL 9000 has contributed the git worktree TOCTOU race condition fix (PR #8178 / issue #7507): replaced the unsafe mkdtemp() + rmdir() pattern with a parent-directory approach to eliminate the race window in concurrent git worktree operations.
|
||||
* HAL 9000 has contributed the git_tools TOCTOU race condition fix (PR #8255 / issue #7619): eliminated the Time-Of-Check-To-Time-Of-Use race in `_get_base_env()` by adding double-checked locking with a module-level `threading.Lock`, preventing concurrent threads from writing conflicting environment snapshots.
|
||||
* HAL 9000 has contributed the mandatory PR compliance checklist to `implementation-pool-supervisor.md` (#10069): created a new agent definition with an embedded 8-item PR Compliance Checklist ensuring workers always update CHANGELOG.md, CONTRIBUTORS.md, include commit footers (`ISSUES CLOSED: #N`), verify CI passes, add BDD tests, reference the parent Epic, apply labels via forgejo-label-manager, and assign milestones before creating PRs. Includes concrete examples for each subsection and compliance verification pseudocode.
|
||||
* HAL 9000 has contributed the `implementation-pool-supervisor` prompt template fix (#10069): embedded the full 8-item PR Compliance Checklist into the prompt template passed to workers (fixing review feedback from PR #11015), and added missing `model` and `reasoningEffort` YAML frontmatter fields matching other supervisor agents.
|
||||
* HAL 9000 has contributed the mandatory PR compliance checklist to `implementation-supervisor.md` (#9824): added an 8-item checklist to the worker prompt body with concrete items covering CHANGELOG.md, CONTRIBUTORS.md, commit footer, CI verification, BDD tests, Epic reference, labels, and milestone assignment to eliminate systemic PR merge blockers.
|
||||
* HAL 9000 has contributed the PlanResult.success derivation fix (PR #8214 / issue #7501): replaced the incorrect `error_message is None` heuristic with a dedicated `result_success` column in the plans table, ensuring plans with historical build errors are not incorrectly marked as failed after a successful apply.
|
||||
* HAL 9000 has contributed the mandatory PR compliance checklist to `implementation-pool-supervisor.md` (#9824): created a new agent definition with an embedded 8-item checklist ensuring workers always update CHANGELOG.md, CONTRIBUTORS.md, include commit footers (`ISSUES CLOSED: #N`), verify CI passes, add BDD tests, reference the parent Epic, apply labels via forgejo-label-manager, and assign milestones before creating PRs. Includes concrete examples for each subsection and compliance verification pseudocode.
|
||||
|
||||
Reference in New Issue
Block a user