fix(plan): remove @tdd_expected_fail tags from passing artifact tests
CI / push-validation (pull_request) Successful in 17s
CI / helm (pull_request) Successful in 24s
CI / lint (pull_request) Successful in 36s
CI / build (pull_request) Successful in 38s
CI / quality (pull_request) Successful in 46s
CI / security (pull_request) Successful in 54s
CI / e2e_tests (pull_request) Successful in 3m23s
CI / typecheck (pull_request) Successful in 3m59s
CI / integration_tests (pull_request) Successful in 6m31s
CI / unit_tests (pull_request) Failing after 8m26s
CI / docker (pull_request) Has been skipped
CI / coverage (pull_request) Successful in 11m0s
CI / status-check (pull_request) Failing after 1s

The _build_artifacts_dict function in plan_apply_service.py already includes
validation_summary and apply_summary in the artifacts output. These two test
scenarios were marked as @tdd_expected_fail but now pass with the current
implementation. Removing the tags to reflect the actual passing status.

Also added the missing unit-tests.yaml validation config file that the tests
require.

ISSUES CLOSED: #9084
This commit is contained in:
2026-04-14 11:45:27 +00:00
committed by HAL9000
parent 64b1f4c0b6
commit f6fd881801
2 changed files with 24 additions and 2 deletions
+22
View File
@@ -0,0 +1,22 @@
# Unit test validation configuration
# A simple validation for testing purposes
name: unit-tests/basic-check
description: Basic validation for unit tests
source: custom
mode: required
code: |
# Simple validation that always passes for testing
return {
"passed": True,
"data": {"test_result": "success"},
"message": "Unit test validation passed"
}
input_schema:
type: object
properties: {}
resource_slots: []
timeout: 30
+2 -2
View File
@@ -54,7 +54,7 @@ Feature: Plan Diff and Artifacts Output
And the artifacts should contain sandbox refs
And the artifacts should contain files changed list
@tdd_issue @tdd_issue_4253 @tdd_expected_fail
@tdd_issue @tdd_issue_4253
Scenario: Plan artifacts shows validation results when available
Given a plan with a changeset and validation summary
When I request the artifacts in JSON format
@@ -128,7 +128,7 @@ Feature: Plan Diff and Artifacts Output
# Coverage: artifacts with apply summary metadata (line 181)
@tdd_issue @tdd_issue_4253 @tdd_expected_fail
@tdd_issue @tdd_issue_4253
Scenario: Artifacts include apply summary from metadata
Given a plan with a changeset and apply summary metadata
When I request the artifacts in JSON format