fix(test): update _FailingConfigService.set_value() to match scoped signature
CI / security (pull_request) Failing after 2s
CI / quality (pull_request) Failing after 2s
CI / e2e_tests (pull_request) Failing after 2s
CI / build (pull_request) Failing after 1s
CI / helm (pull_request) Failing after 1s
CI / typecheck (pull_request) Has been cancelled
CI / integration_tests (pull_request) Has been cancelled
CI / unit_tests (pull_request) Has been cancelled
CI / lint (pull_request) Has been cancelled
CI / status-check (pull_request) Has been cancelled
CI / docker (pull_request) Has been cancelled
CI / coverage (pull_request) Has been cancelled
CI / benchmark-regression (pull_request) Has been cancelled
CI / benchmark-publish (pull_request) Has been cancelled

Update the test double to accept the scope keyword argument added by
master's scoped config changes, and pass project_root=None to avoid
auto-discovery in test environments.

ISSUES CLOSED: #993
This commit is contained in:
2026-04-02 08:33:01 +00:00
committed by Forgejo
parent d614ba2fc0
commit d67fe6cd48
@@ -23,7 +23,7 @@ from unittest.mock import patch
from behave import given, then, when from behave import given, then, when
from behave.runner import Context from behave.runner import Context
from cleveragents.application.services.config_service import ConfigService from cleveragents.application.services.config_service import ConfigScope, ConfigService
from cleveragents.infrastructure.events.reactive import ReactiveEventBus from cleveragents.infrastructure.events.reactive import ReactiveEventBus
from cleveragents.infrastructure.events.types import EventType from cleveragents.infrastructure.events.types import EventType
@@ -62,11 +62,14 @@ class _FailingConfigService(ConfigService):
config_dir=config_dir, config_dir=config_dir,
config_path=config_path, config_path=config_path,
event_bus=event_bus, event_bus=event_bus,
project_root=None,
) )
self._fail_on_call = fail_on_call_number self._fail_on_call = fail_on_call_number
self._call_count = 0 self._call_count = 0
def set_value(self, key: str, value: Any) -> None: def set_value(
self, key: str, value: Any, *, scope: ConfigScope | None = None
) -> None:
"""Override set_value to fail on a specific call number.""" """Override set_value to fail on a specific call number."""
self._call_count += 1 self._call_count += 1
if self._call_count == self._fail_on_call: if self._call_count == self._fail_on_call:
@@ -74,7 +77,7 @@ class _FailingConfigService(ConfigService):
f"Simulated disk failure on set_value call #{self._call_count} " f"Simulated disk failure on set_value call #{self._call_count} "
f"(key={key!r})" f"(key={key!r})"
) )
super().set_value(key, value) super().set_value(key, value, scope=scope)
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
@@ -123,6 +126,7 @@ def step_pre_existing_config(context: Context) -> None:
svc = ConfigService( svc = ConfigService(
config_dir=context.atomic_config_dir, config_dir=context.atomic_config_dir,
config_path=context.atomic_config_path, config_path=context.atomic_config_path,
project_root=None,
) )
svc.set_value("server.url", _ORIGINAL_URL) svc.set_value("server.url", _ORIGINAL_URL)
svc.set_value("server.namespace", _ORIGINAL_NAMESPACE) svc.set_value("server.namespace", _ORIGINAL_NAMESPACE)