From d51f3a05ae94eabbde0395e5446c566463ed8859 Mon Sep 17 00:00:00 2001 From: CleverThis Date: Wed, 22 Apr 2026 07:07:59 +0000 Subject: [PATCH] fix: resolve ambiguous step definition conflict in execution_environment_steps.py - Renamed 'it should contain' steps to 'the container types should contain' for specificity - Updated execution_environment.feature to use the new step names - This fixes the AmbiguousStep error that was preventing unit tests from running --- features/execution_environment.feature | 9 ++++----- features/steps/execution_environment_steps.py | 4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/features/execution_environment.feature b/features/execution_environment.feature index 49907d400..f17af0f65 100644 --- a/features/execution_environment.feature +++ b/features/execution_environment.feature @@ -129,10 +129,10 @@ Feature: Execution environment routing Scenario: CONTAINER_RESOURCE_TYPES includes expected types Given I import CONTAINER_RESOURCE_TYPES - Then it should contain "container-instance" - And it should contain "devcontainer-instance" - And it should not contain "devcontainer-file" - And it should not contain "git-checkout" + Then the container types should contain "container-instance" + And the container types should contain "devcontainer-instance" + And the container types should not contain "devcontainer-file" + And the container types should not contain "git-checkout" # ── ContainerUnavailableError ─────────────────────────────────────── @@ -145,4 +145,3 @@ Feature: Execution environment routing When I create a ContainerUnavailableError without project name Then exec-env the error message should contain "Container resource unavailable" And exec-env the error message should not contain "for project" - diff --git a/features/steps/execution_environment_steps.py b/features/steps/execution_environment_steps.py index 1379ffb40..54349e1c0 100644 --- a/features/steps/execution_environment_steps.py +++ b/features/steps/execution_environment_steps.py @@ -342,12 +342,12 @@ def step_import_types(context: Context) -> None: context.container_types = CONTAINER_RESOURCE_TYPES -@then('it should contain "{value}"') +@then('the container types should contain "{value}"') def step_types_contain(context: Context, value: str) -> None: assert value in context.container_types -@then('it should not contain "{value}"') +@then('the container types should not contain "{value}"') def step_types_not_contain(context: Context, value: str) -> None: assert value not in context.container_types