fix(ci): restore unit_tests dependency on coverage job (PR #10845 v2)

Per review feedback from HAL9001, the coverage job must depend on unit_tests passing to prevent misleading coverage reports when tests fail. Without this dependency, coverage could run and report false-positive pass results even when unit tests are failing — undermining the purpose of the quality gate. Additionally: commit footer ISSUES CLOSED: #1641 included in parent commit. ISSUES CLOSED: #10845
2026-05-11 01:46:17 +00:00
parent c82dabaf7b
commit d1d492d859
1 changed files with 3 additions and 4 deletions
@@ -395,10 +395,9 @@ jobs:
        container:
            image: ${{vars.docker_prefix}}python:3.13-slim
        # Coverage runs the full unit-test suite independently under slipcover.
-        # It no longer waits for lint/typecheck/security/quality -- those jobs
-        # are independent static-analysis checks that do not affect test results.
-        # Removing the unnecessary dependency allows coverage to start immediately
-        # in parallel with all other jobs, cutting the critical path significantly.
+        # It depends on unit_tests so coverage results are only meaningful when
+        # tests actually pass — prevents misleading coverage reports when tests fail.
+        needs: [unit_tests]
        steps:
            - name: Install system dependencies (nodejs for checkout, git for merge tests)
              run: |