fix(plan): update robot helper to assert alternatives key in explain output
CI / benchmark-publish (pull_request) Has been skipped
CI / push-validation (pull_request) Successful in 47s
CI / helm (pull_request) Successful in 49s
CI / build (pull_request) Successful in 1m21s
CI / lint (pull_request) Failing after 1m29s
CI / benchmark-regression (pull_request) Failing after 1m49s
CI / quality (pull_request) Successful in 2m0s
CI / typecheck (pull_request) Successful in 2m20s
CI / security (pull_request) Successful in 2m25s
CI / integration_tests (pull_request) Successful in 4m31s
CI / unit_tests (pull_request) Failing after 5m9s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / e2e_tests (pull_request) Successful in 5m10s
CI / status-check (pull_request) Failing after 3s
CI / benchmark-publish (pull_request) Has been skipped
CI / push-validation (pull_request) Successful in 47s
CI / helm (pull_request) Successful in 49s
CI / build (pull_request) Successful in 1m21s
CI / lint (pull_request) Failing after 1m29s
CI / benchmark-regression (pull_request) Failing after 1m49s
CI / quality (pull_request) Successful in 2m0s
CI / typecheck (pull_request) Successful in 2m20s
CI / security (pull_request) Successful in 2m25s
CI / integration_tests (pull_request) Successful in 4m31s
CI / unit_tests (pull_request) Failing after 5m9s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / e2e_tests (pull_request) Successful in 5m10s
CI / status-check (pull_request) Failing after 3s
The robot/helper_plan_explain.py integration test helper was still asserting the old field name alternatives_considered in the explain dict output. Since _build_explain_dict() now outputs alternatives (structured objects with index/description/chosen fields per spec), the assertion was failing the CI integration_tests job. Updated the assertion to check for alternatives and also verify it is a list, matching the new structured output format.
This commit is contained in:
@@ -49,7 +49,8 @@ def _test_explain_format() -> None:
|
||||
assert "decision_id" in data
|
||||
assert "context_snapshot" in data
|
||||
assert "rationale" in data
|
||||
assert "alternatives_considered" in data
|
||||
assert "alternatives" in data
|
||||
assert isinstance(data["alternatives"], list)
|
||||
assert data["question"] == "What to build?"
|
||||
print("plan-explain-ok")
|
||||
|
||||
|
||||
Reference in New Issue
Block a user