fix(acms): consolidate StrategyCapabilities to single domain model with spec-compliant fields

Removed duplicate StrategyCapabilities dataclass from acms_service.py, imported canonical Pydantic v2 domain model from cleveragents.domain.models.acms.strategy instead.

Updated 6 built-in strategies to use spec-compliant fields:
- SimpleKeywordStrategy: uses_text=True, quality_score=0.3
- SemanticEmbeddingStrategy: uses_vector=True, uses_text=True, quality_score=0.6
- BreadthDepthNavigatorStrategy: uses_graph=True, quality_score=0.85
- ArceStrategy: uses_vector=True, uses_graph=True, uses_temporal=True, quality_score=0.95
- TemporalArchaeologyStrategy: uses_temporal=True, uses_graph=True, quality_score=0.5
- PlanDecisionContextStrategy: uses_temporal=True, quality_score=0.7

Added type guard in SpecStrategyAdapter.capabilities to validate return type.

This fixes StrategyCapabilities typecheck errors and validate_registry() warnings for all 6 built-in strategies.

ISSUES CLOSED: #9161

CHANGELOG.md

@@ -8,6 +8,8 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 ### Fixed
 
 - **Automation Profile Silent Fallback** (#8232): `_resolve_profile_for_plan` in
+
+- **ACMS StrategyCapabilities Consolidation** (#9161): Removed duplicate `StrategyCapabilities` dataclass from `acms_service.py` and unified to the canonical Pydantic v2 domain model from `domain/models/acms/strategy`. Fixed legacy parameter names (`supports_semantic_search`, `supports_graph_navigation`, `supports_temporal_archaeology`) across all strategy implementations in `context_strategies.py` and `acms_advanced_strategies.py`. Added non-empty `resource_types` declarations on all pipeline strategies, resolving `validate_registry()` warnings.
   `PlanLifecycleService` now raises a clear `ValidationError` when a plan's
   automation profile name is not a known built-in profile, instead of silently
   falling back to `"manual"`. Users who configured custom automation profiles

src/cleveragents/application/services/acms_advanced_strategies.py

@@ -31,9 +31,11 @@ from collections.abc import Sequence
 from typing import Any, Final
 
 from cleveragents.application.services.acms_service import (
-    StrategyCapabilities,
     _pack_budget,
 )
+from cleveragents.domain.models.acms.strategy import (
+    StrategyCapabilities,
+)
 from cleveragents.domain.models.core.context_fragment import (
     ContextBudget,
     ContextFragment,
@@ -103,9 +105,10 @@ class ArceStrategy:
     @property
     def capabilities(self) -> StrategyCapabilities:
         return StrategyCapabilities(
-            supports_semantic_search=True,
-            supports_graph_navigation=True,
-            supports_temporal_archaeology=True,
+            uses_vector=True,
+            uses_graph=True,
+            uses_temporal=True,
+            quality_score=0.95,
         )
 
     def can_handle(self, request: dict[str, Any]) -> float:
@@ -265,8 +268,9 @@ class TemporalArchaeologyStrategy:
     @property
     def capabilities(self) -> StrategyCapabilities:
         return StrategyCapabilities(
-            supports_temporal_archaeology=True,
-            supports_graph_navigation=True,
+            uses_temporal=True,
+            uses_graph=True,
+            quality_score=0.5,
         )
 
     def can_handle(self, request: dict[str, Any]) -> float:
@@ -362,7 +366,8 @@ class PlanDecisionContextStrategy:
     @property
     def capabilities(self) -> StrategyCapabilities:
         return StrategyCapabilities(
-            supports_temporal_archaeology=True,
+            uses_temporal=True,
+            quality_score=0.7,
         )
 
     def can_handle(self, request: dict[str, Any]) -> float:

src/cleveragents/application/services/acms_service.py

@@ -24,7 +24,6 @@ from __future__ import annotations
 
 import re
 from collections.abc import Sequence
-from dataclasses import dataclass
 from threading import local
 from typing import TYPE_CHECKING, Any, ClassVar, Protocol, runtime_checkable
 
@@ -38,6 +37,9 @@ if TYPE_CHECKING:
 from cleveragents.domain.models.acms.crp import (
     ContextRequest,
 )
+from cleveragents.domain.models.acms.strategy import (
+    StrategyCapabilities,
+)
 from cleveragents.domain.models.core.context_fragment import (
     ULID_PATTERN,
     ContextBudget,
@@ -94,22 +96,6 @@ def _get_greedy_knapsack_packer_class() -> type:
 logger = structlog.get_logger(__name__)
 
 
-# ---------------------------------------------------------------------------
-# Strategy capabilities (spec ~line 25167)
-# ---------------------------------------------------------------------------
-
-
-@dataclass(frozen=True)
-class StrategyCapabilities:
-    """Capabilities declared by a context strategy."""
-
-    supports_semantic_search: bool = False
-    supports_graph_navigation: bool = False
-    supports_temporal_archaeology: bool = False
-    max_fragments: int | None = None
-    quality_score: float = 1.0
-
-
 # ---------------------------------------------------------------------------
 # Context strategy protocol (spec ~line 25167)
 # ---------------------------------------------------------------------------
@@ -179,7 +165,11 @@ class RelevanceStrategy:
 
     @property
     def capabilities(self) -> StrategyCapabilities:
-        return StrategyCapabilities(supports_semantic_search=True)
+        return StrategyCapabilities(
+            uses_vector=True,
+            resource_types=("file", "snippet"),
+            quality_score=0.8,
+        )
 
     def can_handle(self, request: dict[str, Any]) -> float:
         return 0.8  # general-purpose, high confidence
@@ -211,7 +201,11 @@ class RecencyStrategy:
 
     @property
     def capabilities(self) -> StrategyCapabilities:
-        return StrategyCapabilities(supports_temporal_archaeology=True)
+        return StrategyCapabilities(
+            uses_temporal=True,
+            resource_types=("file", "commit", "event"),
+            quality_score=0.6,
+        )
 
     def can_handle(self, request: dict[str, Any]) -> float:
         return 0.6
@@ -255,7 +249,11 @@ class TieredStrategy:
 
     @property
     def capabilities(self) -> StrategyCapabilities:
-        return StrategyCapabilities()
+        return StrategyCapabilities(
+            uses_text=True,
+            resource_types=("file", "snippet", "summary"),
+            quality_score=0.7,
+        )
 
     def can_handle(self, request: dict[str, Any]) -> float:
         return 0.7
@@ -317,14 +315,8 @@ class SpecStrategyAdapter:
 
     @property
     def capabilities(self) -> StrategyCapabilities:
-        # Bridge: map spec StrategyCapabilities to pipeline StrategyCapabilities.
-        spec_caps = self._spec_strategy.capabilities
-        return StrategyCapabilities(
-            supports_semantic_search=getattr(spec_caps, "uses_vector", False),
-            supports_graph_navigation=getattr(spec_caps, "uses_graph", False),
-            supports_temporal_archaeology=getattr(spec_caps, "uses_temporal", False),
-            quality_score=getattr(spec_caps, "quality_score", 0.5),
-        )
+        # Return the spec strategy's domain-model StrategyCapabilities directly.
+        return self._spec_strategy.capabilities
 
     def can_handle(self, request: dict[str, Any]) -> float:
         """Return the spec strategy's quality score as confidence."""

src/cleveragents/application/services/context_strategies.py

@@ -28,9 +28,11 @@ from collections.abc import Sequence
 from typing import Any
 
 from cleveragents.application.services.acms_service import (
-    StrategyCapabilities,
     _pack_budget,
 )
+from cleveragents.domain.models.acms.strategy import (
+    StrategyCapabilities,
+)
 from cleveragents.domain.models.core.context_fragment import (
     ContextBudget,
     ContextFragment,
@@ -75,7 +77,7 @@ class SimpleKeywordStrategy:
 
     @property
     def capabilities(self) -> StrategyCapabilities:
-        return StrategyCapabilities(supports_semantic_search=False)
+        return StrategyCapabilities(uses_text=True, quality_score=0.3)
 
     def can_handle(self, request: dict[str, Any]) -> float:
         """Return 0.3 confidence — universal fallback."""
@@ -169,7 +171,7 @@ class SemanticEmbeddingStrategy:
 
     @property
     def capabilities(self) -> StrategyCapabilities:
-        return StrategyCapabilities(supports_semantic_search=True)
+        return StrategyCapabilities(uses_vector=True, uses_text=True, quality_score=0.6)
 
     def can_handle(self, request: dict[str, Any]) -> float:
         """Return 0.6 confidence when a query is present, else 0.1."""
@@ -265,7 +267,7 @@ class BreadthDepthNavigatorStrategy:
 
     @property
     def capabilities(self) -> StrategyCapabilities:
-        return StrategyCapabilities(supports_graph_navigation=True)
+        return StrategyCapabilities(uses_graph=True, quality_score=0.85)
 
     def can_handle(self, request: dict[str, Any]) -> float:
         """Return 0.85 when focus nodes are present, else 0.2."""