feat(providers): implement OllamaProvider and MistralProvider
- Implemented OllamaChatProvider to enable local Ollama model support. - Implemented MistralChatProvider to integrate with the Mistral API. - Added Behave BDD tests for both providers. - Updated dependencies: langchain-mistralai and ollama. - Updated provider exports to include the new providers. ISSUES CLOSED: #5257
This commit is contained in:
Forgejo
@@ -0,0 +1,71 @@
|
||||
Feature: Mistral chat provider coverage
|
||||
As a maintainer integrating Mistral API support
|
||||
I want unit-level Behave scenarios for the Mistral chat provider
|
||||
So that the Mistral adapter stays documented and regression tested
|
||||
|
||||
@unit @providers @mistral
|
||||
Scenario: Mistral provider instantiates ChatMistralAI with provided credentials
|
||||
Given I have sample provider domain inputs
|
||||
When I create a Mistral chat provider with API key "test-key-123" and model "mistral-large-latest"
|
||||
And I request plan generation from the Mistral provider
|
||||
Then the Mistral provider should construct ChatMistralAI with api key "test-key-123" and model "mistral-large-latest"
|
||||
And the Mistral provider metadata should report name "mistral" and model "mistral-large-latest"
|
||||
|
||||
@unit @providers @mistral
|
||||
Scenario: Mistral provider stubbed response reports metadata
|
||||
Given I have sample provider domain inputs
|
||||
And I create a Mistral chat provider with API key "test-key-123" and model "mistral-large-latest"
|
||||
When I request plan generation from the Mistral provider
|
||||
Then the Mistral provider response should contain no generated changes
|
||||
And the Mistral provider response should report the requested model without errors
|
||||
|
||||
@unit @providers @mistral
|
||||
Scenario: Mistral provider rejects missing API key
|
||||
Given I have sample provider domain inputs
|
||||
When I attempt to create a Mistral chat provider without an API key
|
||||
Then the Mistral provider creation should fail with error containing "Mistral API key is required"
|
||||
|
||||
@unit @providers @mistral
|
||||
Scenario: Mistral provider reads API key from environment variable
|
||||
Given I have sample provider domain inputs
|
||||
And I set the MISTRAL_API_KEY environment variable to "env-key-456"
|
||||
When I create a Mistral chat provider without explicit API key and model "mistral-large-latest"
|
||||
And I request plan generation from the Mistral provider
|
||||
Then the Mistral provider should construct ChatMistralAI with api key "env-key-456" and model "mistral-large-latest"
|
||||
|
||||
@unit @providers @mistral
|
||||
Scenario: Mistral provider forwards extra kwargs
|
||||
Given I have sample provider domain inputs
|
||||
And I set the Mistral provider extra kwargs "temperature=0.5,max_tokens=512"
|
||||
When I create a Mistral chat provider with API key "test-key-123" and model "mistral-large-latest"
|
||||
And I request plan generation from the Mistral provider
|
||||
Then the Mistral provider should construct ChatMistralAI with api key "test-key-123" and model "mistral-large-latest"
|
||||
And the Mistral provider should include kwargs "temperature=0.5,max_tokens=512" in the ChatMistralAI call
|
||||
|
||||
@unit @providers @mistral
|
||||
Scenario: Mistral provider reports runtime errors
|
||||
Given I have sample provider domain inputs
|
||||
And I create a Mistral chat provider with API key "test-key-123" and model "mistral-large-latest"
|
||||
And the plan generation graph raises RuntimeError "API rate limit exceeded"
|
||||
When I request plan generation from the Mistral provider
|
||||
Then the Mistral provider response should report error "API rate limit exceeded"
|
||||
And the Mistral provider response should contain no generated changes
|
||||
|
||||
@unit @providers @mistral
|
||||
Scenario: Mistral provider streaming yields workflow events
|
||||
Given I have sample provider domain inputs
|
||||
And the plan generation graph returns a generated change for "app/mistral.py"
|
||||
And the plan generation graph emits streaming nodes "load_context,analyze_requirements,generate_plan,validate"
|
||||
And I create a Mistral chat provider with API key "test-key-123" and model "mistral-large-latest"
|
||||
When I stream plan generation from the Mistral provider
|
||||
Then the Mistral provider streaming events should include nodes "load_context,analyze_requirements,generate_plan,validate"
|
||||
And the Mistral provider streaming result should finish with a response containing 1 generated change
|
||||
|
||||
@unit @providers @mistral
|
||||
Scenario: Mistral provider surfaces plan generation errors
|
||||
Given I have sample provider domain inputs
|
||||
And the plan generation graph raises ValueError "invalid request"
|
||||
And I create a Mistral chat provider with API key "test-key-123" and model "mistral-large-latest"
|
||||
When I request plan generation from the Mistral provider
|
||||
Then the Mistral provider response should report error "invalid request"
|
||||
And the Mistral provider response should contain no generated changes
|
||||
@@ -0,0 +1,70 @@
|
||||
Feature: Ollama chat provider coverage
|
||||
As a maintainer integrating local model support
|
||||
I want unit-level Behave scenarios for the Ollama chat provider
|
||||
So that the local model adapter stays documented and regression tested
|
||||
|
||||
@unit @providers @ollama
|
||||
Scenario: Ollama provider instantiates ChatOllama with provided credentials
|
||||
Given I have sample provider domain inputs
|
||||
When I create an Ollama chat provider with model "llama2" and base_url "http://localhost:11434"
|
||||
And I request plan generation from the Ollama provider
|
||||
Then the Ollama provider should construct ChatOllama with model "llama2" and base_url "http://localhost:11434"
|
||||
And the Ollama provider metadata should report name "ollama" and model "llama2"
|
||||
|
||||
@unit @providers @ollama
|
||||
Scenario: Ollama provider stubbed response reports metadata
|
||||
Given I have sample provider domain inputs
|
||||
And I create an Ollama chat provider with model "llama2" and base_url "http://localhost:11434"
|
||||
When I request plan generation from the Ollama provider
|
||||
Then the Ollama provider response should contain no generated changes
|
||||
And the Ollama provider response should report the requested model without errors
|
||||
|
||||
@unit @providers @ollama
|
||||
Scenario: Ollama provider rejects missing model name
|
||||
Given I have sample provider domain inputs
|
||||
When I attempt to create an Ollama chat provider without a model name
|
||||
Then the Ollama provider creation should fail with error "Ollama model name is required"
|
||||
|
||||
@unit @providers @ollama
|
||||
Scenario: Ollama provider uses default base URL
|
||||
Given I have sample provider domain inputs
|
||||
When I create an Ollama chat provider with model "llama2" and default base_url
|
||||
And I request plan generation from the Ollama provider
|
||||
Then the Ollama provider should construct ChatOllama with model "llama2" and base_url "http://localhost:11434"
|
||||
|
||||
@unit @providers @ollama
|
||||
Scenario: Ollama provider forwards extra kwargs
|
||||
Given I have sample provider domain inputs
|
||||
And I set the Ollama provider extra kwargs "temperature=0.7,top_p=0.9"
|
||||
When I create an Ollama chat provider with model "llama2" and base_url "http://localhost:11434"
|
||||
And I request plan generation from the Ollama provider
|
||||
Then the Ollama provider should construct ChatOllama with model "llama2" and base_url "http://localhost:11434"
|
||||
And the Ollama provider should include kwargs "temperature=0.7,top_p=0.9" in the ChatOllama call
|
||||
|
||||
@unit @providers @ollama
|
||||
Scenario: Ollama provider reports runtime errors
|
||||
Given I have sample provider domain inputs
|
||||
And I create an Ollama chat provider with model "llama2" and base_url "http://localhost:11434"
|
||||
And the plan generation graph raises RuntimeError "connection refused"
|
||||
When I request plan generation from the Ollama provider
|
||||
Then the Ollama provider response should report error "connection refused"
|
||||
And the Ollama provider response should contain no generated changes
|
||||
|
||||
@unit @providers @ollama
|
||||
Scenario: Ollama provider streaming yields workflow events
|
||||
Given I have sample provider domain inputs
|
||||
And the plan generation graph returns a generated change for "app/stream.py"
|
||||
And the plan generation graph emits streaming nodes "load_context,analyze_requirements,generate_plan,validate"
|
||||
And I create an Ollama chat provider with model "llama2" and base_url "http://localhost:11434"
|
||||
When I stream plan generation from the Ollama provider
|
||||
Then the Ollama provider streaming events should include nodes "load_context,analyze_requirements,generate_plan,validate"
|
||||
And the Ollama provider streaming result should finish with a response containing 1 generated change
|
||||
|
||||
@unit @providers @ollama
|
||||
Scenario: Ollama provider surfaces plan generation errors
|
||||
Given I have sample provider domain inputs
|
||||
And the plan generation graph raises ValueError "model not found"
|
||||
And I create an Ollama chat provider with model "llama2" and base_url "http://localhost:11434"
|
||||
When I request plan generation from the Ollama provider
|
||||
Then the Ollama provider response should report error "model not found"
|
||||
And the Ollama provider response should contain no generated changes
|
||||
@@ -0,0 +1,333 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import ast
|
||||
import os
|
||||
from typing import Any
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
from behave import given, then, when
|
||||
|
||||
from cleveragents.domain.models.core import (
|
||||
Context,
|
||||
OperationType,
|
||||
Plan,
|
||||
Project,
|
||||
)
|
||||
from cleveragents.providers.llm.mistral_provider import MistralChatProvider
|
||||
|
||||
|
||||
def _register_cleanup(context, cleanup):
|
||||
if hasattr(context, "add_cleanup"):
|
||||
context.add_cleanup(cleanup)
|
||||
else:
|
||||
cleanup_handlers = getattr(context, "_cleanup_handlers", [])
|
||||
cleanup_handlers.append(cleanup)
|
||||
context._cleanup_handlers = cleanup_handlers
|
||||
|
||||
|
||||
def _parse_kwargs_string(kwargs_string: str) -> dict[str, Any]:
|
||||
if not kwargs_string:
|
||||
return {}
|
||||
result: dict[str, Any] = {}
|
||||
for entry in kwargs_string.split(","):
|
||||
entry = entry.strip()
|
||||
if not entry:
|
||||
continue
|
||||
if "=" not in entry:
|
||||
result[entry] = True
|
||||
continue
|
||||
key, value = entry.split("=", 1)
|
||||
key = key.strip()
|
||||
value = value.strip()
|
||||
try:
|
||||
parsed_value = ast.literal_eval(value)
|
||||
except Exception:
|
||||
parsed_value = value
|
||||
result[key] = parsed_value
|
||||
return result
|
||||
|
||||
|
||||
def _setup_plan_generation_graph(context) -> MagicMock:
|
||||
patcher = patch(
|
||||
"cleveragents.providers.llm.langchain_chat_provider.PlanGenerationGraph"
|
||||
)
|
||||
context.plan_generation_patcher = patcher
|
||||
mock_graph_class = patcher.start()
|
||||
_register_cleanup(context, patcher.stop)
|
||||
mock_graph_instance = MagicMock(name="PlanGenerationGraphInstance")
|
||||
|
||||
default_state = {
|
||||
"generated_changes": [],
|
||||
"validation_result": {"status": "PASS"},
|
||||
"error": None,
|
||||
}
|
||||
state_override = getattr(context, "plan_generation_state_override", None)
|
||||
mock_graph_instance.invoke.return_value = state_override or default_state
|
||||
|
||||
invoke_side_effect = getattr(context, "plan_generation_invoke_side_effect", None)
|
||||
if invoke_side_effect is not None:
|
||||
mock_graph_instance.invoke.side_effect = invoke_side_effect
|
||||
|
||||
stream_events = getattr(context, "plan_generation_stream_events", None)
|
||||
if stream_events is None:
|
||||
mock_graph_instance.stream.return_value = iter(())
|
||||
else:
|
||||
events_copy = list(stream_events)
|
||||
|
||||
def _stream(*_args, **_kwargs):
|
||||
yield from events_copy
|
||||
|
||||
mock_graph_instance.stream.side_effect = _stream
|
||||
|
||||
mock_graph_class.return_value = mock_graph_instance
|
||||
context.plan_generation_graph = mock_graph_instance
|
||||
context.plan_generation_graph_class = mock_graph_class
|
||||
return mock_graph_instance
|
||||
|
||||
|
||||
@given("I have sample provider domain inputs")
|
||||
def step_sample_provider_inputs(context):
|
||||
context.project = MagicMock(spec=Project)
|
||||
context.plan = MagicMock(spec=Plan)
|
||||
context.plan.prompt = "Add placeholder coverage"
|
||||
context.contexts = [MagicMock(spec=Context)]
|
||||
context.contexts[0].content = "Sample context entry"
|
||||
|
||||
|
||||
@given('the plan generation graph returns a generated change for "{file_path}"')
|
||||
def step_plan_generation_returns_change(context, file_path):
|
||||
change = {
|
||||
"plan_id": 1,
|
||||
"file_path": file_path,
|
||||
"operation": OperationType.MODIFY.value,
|
||||
"new_content": "# updated content",
|
||||
}
|
||||
context.plan_generation_state_override = {
|
||||
"generated_changes": [change],
|
||||
"validation_result": {"status": "PASS"},
|
||||
"error": None,
|
||||
}
|
||||
|
||||
|
||||
@given('the plan generation graph emits streaming nodes "{node_list}"')
|
||||
def step_plan_generation_stream_nodes(context, node_list):
|
||||
nodes = [node.strip() for node in node_list.split(",") if node.strip()]
|
||||
state = getattr(context, "plan_generation_state_override", {}) or {}
|
||||
events: list[dict[str, Any]] = []
|
||||
for node in nodes:
|
||||
payload: dict[str, Any] = {"status": "completed"}
|
||||
if node == "generate_plan" and isinstance(state.get("generated_changes"), list):
|
||||
payload = {
|
||||
"generated_changes": state["generated_changes"],
|
||||
"status": "completed",
|
||||
}
|
||||
elif node == "validate" and isinstance(state.get("validation_result"), dict):
|
||||
payload = {
|
||||
"validation_result": state["validation_result"],
|
||||
"status": "completed",
|
||||
}
|
||||
events.append({node: payload})
|
||||
context.plan_generation_stream_events = events
|
||||
|
||||
|
||||
@given('the plan generation graph raises ValueError "{message}"')
|
||||
def step_plan_generation_raises_value_error(context, message):
|
||||
context.plan_generation_invoke_side_effect = ValueError(message)
|
||||
|
||||
|
||||
@given('the plan generation graph raises RuntimeError "{message}"')
|
||||
def step_plan_generation_runtime_error(context, message):
|
||||
context.plan_generation_invoke_side_effect = RuntimeError(message)
|
||||
|
||||
|
||||
@given('I set the MISTRAL_API_KEY environment variable to "{api_key}"')
|
||||
def step_set_mistral_env_var(context, api_key):
|
||||
context.mistral_env_api_key = api_key
|
||||
os.environ["MISTRAL_API_KEY"] = api_key
|
||||
_register_cleanup(context, lambda: os.environ.pop("MISTRAL_API_KEY", None))
|
||||
|
||||
|
||||
@given('I set the Mistral provider extra kwargs "{kwargs_string}"')
|
||||
def step_set_mistral_provider_kwargs(context, kwargs_string):
|
||||
context.mistral_provider_kwargs = _parse_kwargs_string(kwargs_string)
|
||||
|
||||
|
||||
@given(
|
||||
'I create a Mistral chat provider with API key "{api_key}" and model "{model}"'
|
||||
)
|
||||
@when(
|
||||
'I create a Mistral chat provider with API key "{api_key}" and model "{model}"'
|
||||
)
|
||||
def step_create_mistral_provider(context, api_key, model):
|
||||
patcher = patch("cleveragents.providers.llm.mistral_provider.ChatMistralAI")
|
||||
context.chat_mistral_patcher = patcher
|
||||
mock_chat_mistral_class = patcher.start()
|
||||
_register_cleanup(context, patcher.stop)
|
||||
mock_chat_mistral_instance = MagicMock(name="ChatMistralAIInstance")
|
||||
mock_chat_mistral_instance.get_num_tokens = MagicMock(return_value=0)
|
||||
mock_chat_mistral_class.return_value = mock_chat_mistral_instance
|
||||
|
||||
extra_kwargs = dict(getattr(context, "mistral_provider_kwargs", {}))
|
||||
|
||||
context.provider = MistralChatProvider(
|
||||
api_key=api_key,
|
||||
model=model,
|
||||
**extra_kwargs,
|
||||
)
|
||||
context.chat_mistral_class = mock_chat_mistral_class
|
||||
context.chat_mistral_instance = mock_chat_mistral_instance
|
||||
|
||||
|
||||
@when(
|
||||
'I create a Mistral chat provider without explicit API key and model "{model}"'
|
||||
)
|
||||
def step_create_mistral_provider_from_env(context, model):
|
||||
patcher = patch("cleveragents.providers.llm.mistral_provider.ChatMistralAI")
|
||||
context.chat_mistral_patcher = patcher
|
||||
mock_chat_mistral_class = patcher.start()
|
||||
_register_cleanup(context, patcher.stop)
|
||||
mock_chat_mistral_instance = MagicMock(name="ChatMistralAIInstance")
|
||||
mock_chat_mistral_instance.get_num_tokens = MagicMock(return_value=0)
|
||||
mock_chat_mistral_class.return_value = mock_chat_mistral_instance
|
||||
|
||||
extra_kwargs = dict(getattr(context, "mistral_provider_kwargs", {}))
|
||||
|
||||
context.provider = MistralChatProvider(
|
||||
model=model,
|
||||
**extra_kwargs,
|
||||
)
|
||||
context.chat_mistral_class = mock_chat_mistral_class
|
||||
context.chat_mistral_instance = mock_chat_mistral_instance
|
||||
|
||||
|
||||
@when("I attempt to create a Mistral chat provider without an API key")
|
||||
def step_mistral_provider_without_api_key(context):
|
||||
context.mistral_provider_error = None
|
||||
# Make sure env var is not set
|
||||
os.environ.pop("MISTRAL_API_KEY", None)
|
||||
try:
|
||||
MistralChatProvider(api_key="", model="mistral-large-latest")
|
||||
except Exception as exc: # pragma: no cover - defensive logging only
|
||||
context.mistral_provider_error = exc
|
||||
|
||||
|
||||
@when("I request plan generation from the Mistral provider")
|
||||
def step_request_plan_generation(context):
|
||||
_setup_plan_generation_graph(context)
|
||||
|
||||
context.response = context.provider.generate_changes(
|
||||
context.project,
|
||||
context.plan,
|
||||
context.contexts,
|
||||
)
|
||||
context.chat_mistral_call = context.chat_mistral_class.call_args
|
||||
context.plan_generation_graph_call = context.plan_generation_graph_class.call_args
|
||||
|
||||
|
||||
@when("I stream plan generation from the Mistral provider")
|
||||
def step_stream_plan_generation(context):
|
||||
_setup_plan_generation_graph(context)
|
||||
context.streamed_events = list(
|
||||
context.provider.stream_changes(
|
||||
context.project,
|
||||
context.plan,
|
||||
context.contexts,
|
||||
)
|
||||
)
|
||||
context.chat_mistral_call = context.chat_mistral_class.call_args
|
||||
context.plan_generation_graph_call = context.plan_generation_graph_class.call_args
|
||||
|
||||
|
||||
@then(
|
||||
'the Mistral provider should construct ChatMistralAI with api key "{api_key}" and model "{model}"'
|
||||
)
|
||||
def step_assert_chat_mistral_constructor(context, api_key, model):
|
||||
assert context.chat_mistral_call is not None, "ChatMistralAI should have been called"
|
||||
call_args, call_kwargs = context.chat_mistral_call
|
||||
assert call_args == (), "ChatMistralAI should be called with keyword arguments"
|
||||
assert call_kwargs["api_key"] == api_key
|
||||
assert call_kwargs["model"] == model
|
||||
|
||||
assert context.plan_generation_graph_call is not None, (
|
||||
"PlanGenerationGraph should receive the ChatMistralAI instance"
|
||||
)
|
||||
_, graph_kwargs = context.plan_generation_graph_call
|
||||
assert graph_kwargs["llm"] is context.chat_mistral_instance
|
||||
|
||||
|
||||
@then(
|
||||
'the Mistral provider should include kwargs "{kwargs_string}" in the ChatMistralAI call'
|
||||
)
|
||||
def step_assert_chat_mistral_kwargs(context, kwargs_string):
|
||||
assert context.chat_mistral_call is not None, "ChatMistralAI should have been called"
|
||||
_, call_kwargs = context.chat_mistral_call
|
||||
expected_kwargs = _parse_kwargs_string(kwargs_string)
|
||||
for key, value in expected_kwargs.items():
|
||||
assert key in call_kwargs, f"Expected {key} in ChatMistralAI kwargs"
|
||||
assert call_kwargs[key] == value, (
|
||||
f"Expected ChatMistralAI kwargs[{key!r}] to equal {value!r}"
|
||||
)
|
||||
|
||||
|
||||
@then(
|
||||
'the Mistral provider metadata should report name "{expected_name}" and model "{expected_model}"'
|
||||
)
|
||||
def step_assert_provider_metadata(context, expected_name, expected_model):
|
||||
provider = getattr(context, "provider", None)
|
||||
assert provider is not None, "Provider should exist"
|
||||
assert provider.name == expected_name
|
||||
assert provider.model_id == expected_model
|
||||
response = getattr(context, "response", None)
|
||||
if response is not None:
|
||||
assert response.model_used == expected_model
|
||||
|
||||
|
||||
@then("the Mistral provider response should report the requested model without errors")
|
||||
def step_assert_placeholder_metadata(context):
|
||||
assert context.response is not None
|
||||
assert context.response.model_used == context.provider.model_id
|
||||
assert context.response.error_message in (None, "")
|
||||
|
||||
|
||||
@then("the Mistral provider response should contain no generated changes")
|
||||
def step_assert_no_changes(context):
|
||||
assert context.response is not None, "Provider response should exist"
|
||||
assert len(context.response.changes) == 0, "Expected no generated changes"
|
||||
|
||||
|
||||
@then('the Mistral provider response should report error "{message}"')
|
||||
def step_assert_response_error(context, message):
|
||||
assert context.response is not None
|
||||
assert context.response.error_message == message
|
||||
|
||||
|
||||
@then('the Mistral provider streaming events should include nodes "{node_list}"')
|
||||
def step_assert_stream_events(context, node_list):
|
||||
expected = [node.strip() for node in node_list.split(",") if node.strip()]
|
||||
actual = [
|
||||
next(iter(event.keys()))
|
||||
for event in getattr(context, "streamed_events", [])
|
||||
if "__end__" not in event
|
||||
]
|
||||
assert actual == expected
|
||||
|
||||
|
||||
@then(
|
||||
"the Mistral provider streaming result should finish with a response containing {count:d} generated change"
|
||||
)
|
||||
def step_assert_stream_final_response(context, count):
|
||||
events = getattr(context, "streamed_events", [])
|
||||
assert events, "Expected streamed events"
|
||||
final_event = events[-1]
|
||||
assert "__end__" in final_event, "Expected final __end__ event"
|
||||
response = final_event["__end__"].get("response")
|
||||
assert response is not None, "Expected ProviderResponse in __end__ event"
|
||||
assert len(response.changes) == count
|
||||
|
||||
|
||||
@then('the Mistral provider creation should fail with error containing "{message}"')
|
||||
def step_assert_mistral_provider_error(context, message):
|
||||
error = getattr(context, "mistral_provider_error", None)
|
||||
assert error is not None, "Expected the provider to raise an error"
|
||||
assert isinstance(error, ValueError)
|
||||
assert message in str(error)
|
||||
@@ -0,0 +1,321 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import ast
|
||||
from typing import Any
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
from behave import given, then, when
|
||||
|
||||
from cleveragents.domain.models.core import (
|
||||
Context,
|
||||
OperationType,
|
||||
Plan,
|
||||
Project,
|
||||
)
|
||||
from cleveragents.providers.llm.ollama_provider import OllamaChatProvider
|
||||
|
||||
|
||||
def _register_cleanup(context, cleanup):
|
||||
if hasattr(context, "add_cleanup"):
|
||||
context.add_cleanup(cleanup)
|
||||
else:
|
||||
cleanup_handlers = getattr(context, "_cleanup_handlers", [])
|
||||
cleanup_handlers.append(cleanup)
|
||||
context._cleanup_handlers = cleanup_handlers
|
||||
|
||||
|
||||
def _parse_kwargs_string(kwargs_string: str) -> dict[str, Any]:
|
||||
if not kwargs_string:
|
||||
return {}
|
||||
result: dict[str, Any] = {}
|
||||
for entry in kwargs_string.split(","):
|
||||
entry = entry.strip()
|
||||
if not entry:
|
||||
continue
|
||||
if "=" not in entry:
|
||||
result[entry] = True
|
||||
continue
|
||||
key, value = entry.split("=", 1)
|
||||
key = key.strip()
|
||||
value = value.strip()
|
||||
try:
|
||||
parsed_value = ast.literal_eval(value)
|
||||
except Exception:
|
||||
parsed_value = value
|
||||
result[key] = parsed_value
|
||||
return result
|
||||
|
||||
|
||||
def _setup_plan_generation_graph(context) -> MagicMock:
|
||||
patcher = patch(
|
||||
"cleveragents.providers.llm.langchain_chat_provider.PlanGenerationGraph"
|
||||
)
|
||||
context.plan_generation_patcher = patcher
|
||||
mock_graph_class = patcher.start()
|
||||
_register_cleanup(context, patcher.stop)
|
||||
mock_graph_instance = MagicMock(name="PlanGenerationGraphInstance")
|
||||
|
||||
default_state = {
|
||||
"generated_changes": [],
|
||||
"validation_result": {"status": "PASS"},
|
||||
"error": None,
|
||||
}
|
||||
state_override = getattr(context, "plan_generation_state_override", None)
|
||||
mock_graph_instance.invoke.return_value = state_override or default_state
|
||||
|
||||
invoke_side_effect = getattr(context, "plan_generation_invoke_side_effect", None)
|
||||
if invoke_side_effect is not None:
|
||||
mock_graph_instance.invoke.side_effect = invoke_side_effect
|
||||
|
||||
stream_events = getattr(context, "plan_generation_stream_events", None)
|
||||
if stream_events is None:
|
||||
mock_graph_instance.stream.return_value = iter(())
|
||||
else:
|
||||
events_copy = list(stream_events)
|
||||
|
||||
def _stream(*_args, **_kwargs):
|
||||
yield from events_copy
|
||||
|
||||
mock_graph_instance.stream.side_effect = _stream
|
||||
|
||||
mock_graph_class.return_value = mock_graph_instance
|
||||
context.plan_generation_graph = mock_graph_instance
|
||||
context.plan_generation_graph_class = mock_graph_class
|
||||
return mock_graph_instance
|
||||
|
||||
|
||||
@given("I have sample provider domain inputs")
|
||||
def step_sample_provider_inputs(context):
|
||||
context.project = MagicMock(spec=Project)
|
||||
context.plan = MagicMock(spec=Plan)
|
||||
context.plan.prompt = "Add placeholder coverage"
|
||||
context.contexts = [MagicMock(spec=Context)]
|
||||
context.contexts[0].content = "Sample context entry"
|
||||
|
||||
|
||||
@given('the plan generation graph returns a generated change for "{file_path}"')
|
||||
def step_plan_generation_returns_change(context, file_path):
|
||||
change = {
|
||||
"plan_id": 1,
|
||||
"file_path": file_path,
|
||||
"operation": OperationType.MODIFY.value,
|
||||
"new_content": "# updated content",
|
||||
}
|
||||
context.plan_generation_state_override = {
|
||||
"generated_changes": [change],
|
||||
"validation_result": {"status": "PASS"},
|
||||
"error": None,
|
||||
}
|
||||
|
||||
|
||||
@given('the plan generation graph emits streaming nodes "{node_list}"')
|
||||
def step_plan_generation_stream_nodes(context, node_list):
|
||||
nodes = [node.strip() for node in node_list.split(",") if node.strip()]
|
||||
state = getattr(context, "plan_generation_state_override", {}) or {}
|
||||
events: list[dict[str, Any]] = []
|
||||
for node in nodes:
|
||||
payload: dict[str, Any] = {"status": "completed"}
|
||||
if node == "generate_plan" and isinstance(state.get("generated_changes"), list):
|
||||
payload = {
|
||||
"generated_changes": state["generated_changes"],
|
||||
"status": "completed",
|
||||
}
|
||||
elif node == "validate" and isinstance(state.get("validation_result"), dict):
|
||||
payload = {
|
||||
"validation_result": state["validation_result"],
|
||||
"status": "completed",
|
||||
}
|
||||
events.append({node: payload})
|
||||
context.plan_generation_stream_events = events
|
||||
|
||||
|
||||
@given('the plan generation graph raises ValueError "{message}"')
|
||||
def step_plan_generation_raises_value_error(context, message):
|
||||
context.plan_generation_invoke_side_effect = ValueError(message)
|
||||
|
||||
|
||||
@given('the plan generation graph raises RuntimeError "{message}"')
|
||||
def step_plan_generation_runtime_error(context, message):
|
||||
context.plan_generation_invoke_side_effect = RuntimeError(message)
|
||||
|
||||
|
||||
@given('I set the Ollama provider extra kwargs "{kwargs_string}"')
|
||||
def step_set_ollama_provider_kwargs(context, kwargs_string):
|
||||
context.ollama_provider_kwargs = _parse_kwargs_string(kwargs_string)
|
||||
|
||||
|
||||
@given(
|
||||
'I create an Ollama chat provider with model "{model}" and base_url "{base_url}"'
|
||||
)
|
||||
@when(
|
||||
'I create an Ollama chat provider with model "{model}" and base_url "{base_url}"'
|
||||
)
|
||||
def step_create_ollama_provider(context, model, base_url):
|
||||
patcher = patch("cleveragents.providers.llm.ollama_provider.ChatOllama")
|
||||
context.chat_ollama_patcher = patcher
|
||||
mock_chat_ollama_class = patcher.start()
|
||||
_register_cleanup(context, patcher.stop)
|
||||
mock_chat_ollama_instance = MagicMock(name="ChatOllamaInstance")
|
||||
mock_chat_ollama_instance.get_num_tokens = MagicMock(return_value=0)
|
||||
mock_chat_ollama_class.return_value = mock_chat_ollama_instance
|
||||
|
||||
extra_kwargs = dict(getattr(context, "ollama_provider_kwargs", {}))
|
||||
|
||||
context.provider = OllamaChatProvider(
|
||||
model=model,
|
||||
base_url=base_url,
|
||||
**extra_kwargs,
|
||||
)
|
||||
context.chat_ollama_class = mock_chat_ollama_class
|
||||
context.chat_ollama_instance = mock_chat_ollama_instance
|
||||
|
||||
|
||||
@when('I create an Ollama chat provider with model "{model}" and default base_url')
|
||||
def step_create_ollama_provider_default_url(context, model):
|
||||
patcher = patch("cleveragents.providers.llm.ollama_provider.ChatOllama")
|
||||
context.chat_ollama_patcher = patcher
|
||||
mock_chat_ollama_class = patcher.start()
|
||||
_register_cleanup(context, patcher.stop)
|
||||
mock_chat_ollama_instance = MagicMock(name="ChatOllamaInstance")
|
||||
mock_chat_ollama_instance.get_num_tokens = MagicMock(return_value=0)
|
||||
mock_chat_ollama_class.return_value = mock_chat_ollama_instance
|
||||
|
||||
extra_kwargs = dict(getattr(context, "ollama_provider_kwargs", {}))
|
||||
|
||||
context.provider = OllamaChatProvider(
|
||||
model=model,
|
||||
**extra_kwargs,
|
||||
)
|
||||
context.chat_ollama_class = mock_chat_ollama_class
|
||||
context.chat_ollama_instance = mock_chat_ollama_instance
|
||||
|
||||
|
||||
@when("I attempt to create an Ollama chat provider without a model name")
|
||||
def step_ollama_provider_without_model(context):
|
||||
context.ollama_provider_error = None
|
||||
try:
|
||||
OllamaChatProvider(model="")
|
||||
except Exception as exc: # pragma: no cover - defensive logging only
|
||||
context.ollama_provider_error = exc
|
||||
|
||||
|
||||
@when("I request plan generation from the Ollama provider")
|
||||
def step_request_plan_generation(context):
|
||||
_setup_plan_generation_graph(context)
|
||||
|
||||
context.response = context.provider.generate_changes(
|
||||
context.project,
|
||||
context.plan,
|
||||
context.contexts,
|
||||
)
|
||||
context.chat_ollama_call = context.chat_ollama_class.call_args
|
||||
context.plan_generation_graph_call = context.plan_generation_graph_class.call_args
|
||||
|
||||
|
||||
@when("I stream plan generation from the Ollama provider")
|
||||
def step_stream_plan_generation(context):
|
||||
_setup_plan_generation_graph(context)
|
||||
context.streamed_events = list(
|
||||
context.provider.stream_changes(
|
||||
context.project,
|
||||
context.plan,
|
||||
context.contexts,
|
||||
)
|
||||
)
|
||||
context.chat_ollama_call = context.chat_ollama_class.call_args
|
||||
context.plan_generation_graph_call = context.plan_generation_graph_class.call_args
|
||||
|
||||
|
||||
@then(
|
||||
'the Ollama provider should construct ChatOllama with model "{model}" and base_url "{base_url}"'
|
||||
)
|
||||
def step_assert_chat_ollama_constructor(context, model, base_url):
|
||||
assert context.chat_ollama_call is not None, "ChatOllama should have been called"
|
||||
call_args, call_kwargs = context.chat_ollama_call
|
||||
assert call_args == (), "ChatOllama should be called with keyword arguments"
|
||||
assert call_kwargs["model"] == model
|
||||
assert call_kwargs["base_url"] == base_url
|
||||
|
||||
assert context.plan_generation_graph_call is not None, (
|
||||
"PlanGenerationGraph should receive the ChatOllama instance"
|
||||
)
|
||||
_, graph_kwargs = context.plan_generation_graph_call
|
||||
assert graph_kwargs["llm"] is context.chat_ollama_instance
|
||||
|
||||
|
||||
@then(
|
||||
'the Ollama provider should include kwargs "{kwargs_string}" in the ChatOllama call'
|
||||
)
|
||||
def step_assert_chat_ollama_kwargs(context, kwargs_string):
|
||||
assert context.chat_ollama_call is not None, "ChatOllama should have been called"
|
||||
_, call_kwargs = context.chat_ollama_call
|
||||
expected_kwargs = _parse_kwargs_string(kwargs_string)
|
||||
for key, value in expected_kwargs.items():
|
||||
assert key in call_kwargs, f"Expected {key} in ChatOllama kwargs"
|
||||
assert call_kwargs[key] == value, (
|
||||
f"Expected ChatOllama kwargs[{key!r}] to equal {value!r}"
|
||||
)
|
||||
|
||||
|
||||
@then(
|
||||
'the Ollama provider metadata should report name "{expected_name}" and model "{expected_model}"'
|
||||
)
|
||||
def step_assert_provider_metadata(context, expected_name, expected_model):
|
||||
provider = getattr(context, "provider", None)
|
||||
assert provider is not None, "Provider should exist"
|
||||
assert provider.name == expected_name
|
||||
assert provider.model_id == expected_model
|
||||
response = getattr(context, "response", None)
|
||||
if response is not None:
|
||||
assert response.model_used == expected_model
|
||||
|
||||
|
||||
@then("the Ollama provider response should report the requested model without errors")
|
||||
def step_assert_placeholder_metadata(context):
|
||||
assert context.response is not None
|
||||
assert context.response.model_used == context.provider.model_id
|
||||
assert context.response.error_message in (None, "")
|
||||
|
||||
|
||||
@then("the Ollama provider response should contain no generated changes")
|
||||
def step_assert_no_changes(context):
|
||||
assert context.response is not None, "Provider response should exist"
|
||||
assert len(context.response.changes) == 0, "Expected no generated changes"
|
||||
|
||||
|
||||
@then('the Ollama provider response should report error "{message}"')
|
||||
def step_assert_response_error(context, message):
|
||||
assert context.response is not None
|
||||
assert context.response.error_message == message
|
||||
|
||||
|
||||
@then('the Ollama provider streaming events should include nodes "{node_list}"')
|
||||
def step_assert_stream_events(context, node_list):
|
||||
expected = [node.strip() for node in node_list.split(",") if node.strip()]
|
||||
actual = [
|
||||
next(iter(event.keys()))
|
||||
for event in getattr(context, "streamed_events", [])
|
||||
if "__end__" not in event
|
||||
]
|
||||
assert actual == expected
|
||||
|
||||
|
||||
@then(
|
||||
"the Ollama provider streaming result should finish with a response containing {count:d} generated change"
|
||||
)
|
||||
def step_assert_stream_final_response(context, count):
|
||||
events = getattr(context, "streamed_events", [])
|
||||
assert events, "Expected streamed events"
|
||||
final_event = events[-1]
|
||||
assert "__end__" in final_event, "Expected final __end__ event"
|
||||
response = final_event["__end__"].get("response")
|
||||
assert response is not None, "Expected ProviderResponse in __end__ event"
|
||||
assert len(response.changes) == count
|
||||
|
||||
|
||||
@then('the Ollama provider creation should fail with error "{message}"')
|
||||
def step_assert_ollama_provider_error(context, message):
|
||||
error = getattr(context, "ollama_provider_error", None)
|
||||
assert error is not None, "Expected the provider to raise an error"
|
||||
assert isinstance(error, ValueError)
|
||||
assert str(error) == message
|
||||
Reference in New Issue
Block a user