fix(data-integrity): remove silent argument swap in ValidationAttachmentRepository.attach

- Removed unused imports (typing.Any, BusinessRuleViolation) from step module
- Added CHANGELOG.md entry documenting the data integrity fix
- HAL 9000 already listed in CONTRIBUTORS.md

CHANGELOG.md

@@ -7,6 +7,13 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
 ### Added
 
+- **Data Integrity Fix: ValidationAttachmentRepository Argument Swap** (#7492):
+  Fixed a critical data integrity issue in `ValidationAttachmentRepository.attach`
+  where arguments were being silently swapped during method invocation. The incorrect
+  argument order caused data to be stored with reversed parameters, leading to subtle
+  but serious data corruption without any error being raised. Arguments are now passed
+  in the correct sequence, ensuring data is stored with proper parameter values.
+
 - **Git Worktree Sandbox Apply** (#4454): The `plan apply` command now merges
   LLM-generated changes via `git merge` from an isolated worktree branch
   instead of flat `shutil.copy2`.  Displays spec-aligned Apply Summary

features/steps/tdd_issue_7492_validation_attachment_argument_swap_steps.py

@@ -7,7 +7,6 @@ swap validation_name and resource_id when resource_id contains a slash.
 from __future__ import annotations
 
 import json
-from typing import Any
 
 from behave import given, then, when
 from behave.runner import Context
@@ -18,7 +17,6 @@ from cleveragents.infrastructure.database.models import Base
 from cleveragents.infrastructure.database.repositories import (
     ValidationAttachmentRepository,
 )
-from cleveragents.core.exceptions import BusinessRuleViolation
 
 
 # ---------------------------------------------------------------------------