fix(plan-lifecycle): add rollback_plan method to PlanLifecycleService

- What was implemented
  - Added PLAN_ROLLED_BACK event type to the EventType enum at src/cleveragents/infrastructure/events/types.py to properly represent successful rollbacks in the domain model.
  - Implemented rollback_plan(plan_id: str, checkpoint_id: str) -> RollbackResult in PlanLifecycleService (src/cleveragents/application/services/plan_lifecycle_service.py) with:
    - Plan state validation: rejects rollback when the plan is in terminal APPLIED or CANCELLED states.
    - Delegation to CheckpointService.selective_rollback() to perform the actual rollback logic and obtain a RollbackResult.
    - Emission of PLAN_ROLLED_BACK as a domain event to reflect the completed rollback.
    - checkpoint_service is accepted as an optional constructor parameter; if not provided, a PlanError is raised to preserve backward compatibility.
  - Updated CLI behavior in src/cleveragents/cli/commands/plan.py so agents plan rollback routes through PlanLifecycleService.rollback_plan() rather than calling CheckpointService.selective_rollback() directly.
  - Updated PlanLifecycleService module docstring to include rollback_plan in the documented API.
  - Added Behave feature file features/plan_lifecycle_rollback.feature with 11 scenarios covering state validation, domain events, and delegation.
  - Added step implementations in features/steps/plan_lifecycle_rollback_steps.py to support the new scenarios.

- Key design decisions
  - rollback_plan returns RollbackResult (the same result type produced by CheckpointService.selective_rollback) so the CLI can display rollback details consistently.
  - Terminal states APPLIED and CANCELLED are disallowed for rollback to prevent inconsistent or invalid state transitions.
  - checkpoint_service is optional in the PlanLifecycleService constructor; when omitted (None), a PlanError is raised to retain backward compatibility while signaling explicit dependency requirements.
  - CLI UI remains powered by CheckpointService for metadata enrichment (e.g., confirmation prompts), but the actual rollback action is performed via PlanLifecycleService to ensure proper domain workflow and event emission.

- Technical implications
  - All rollback logic now flows through the domain service layer (PlanLifecycleService) to preserve invariants and emit domain events, rather than allowing ad-hoc UI routes to bypass service validation.
  - The UI can still retrieve checkpoint metadata for user confirmation, but the operation that modifies state uses the new rollback_plan pathway.
  - Tests and behavior coverage were expanded via the new Behave feature and step implementations to validate state handling, events, and delegation.

- Affected modules/components
  - src/cleveragents/infrastructure/events/types.py
  - src/cleveragents/application/services/plan_lifecycle_service.py
  - src/cleveragents/cli/commands/plan.py
  - PlanLifecycleService module docstring
  - features/plan_lifecycle_rollback.feature
  - features/steps/plan_lifecycle_rollback_steps.py

ISSUES CLOSED: #3677

This commit is contained in:

Jeffrey Phillips Freeman

2026-04-06 07:20:06 +00:00

committed by

Forgejo

parent 6bb0e6ddc1

commit 7fb3fc76c8

19 changed files with 1714 additions and 81 deletions

robot/container_tool_exec.robot

+4 -1

View File

@@ -146,7 +146,10 @@ ToolRunner Container Routing Without Executor Returns Error
     ...    s = ToolSpec(name='t', description='d', input_schema={}, handler=lambda x: x)
     ...    r.get.return_value = s
     ...    ev = MagicMock(spec=ExecutionEnvironmentResolver)
     ...    ev.resolve_and_validate.return_value = ExecutionEnvironment.CONTAINER
     ...    # ToolRunner uses resolve_with_precedence() (not resolve_and_validate())
     ...    ev.resolve_with_precedence.return_value = ExecutionEnvironment.CONTAINER
     ...    ev.has_devcontainer.return_value = False
     ...    ev.validate_container_available.return_value = None
     ...    runner = ToolRunner(registry=r, execution_environment_resolver=ev)
     ...    res = runner.execute('t', {})
     ...    assert not res.success, f"Expected failure but got success"