fix(concurrency): remove type:ignore and fix lint issues in thread safety helpers

features/steps/invariant_service_thread_safety_mixed_steps.py

@@ -7,7 +7,6 @@ Covers: mixed operations, effective invariants, and shared assertions.
 from __future__ import annotations
 
 import threading
-import time
 from concurrent.futures import ThreadPoolExecutor, as_completed
 from typing import Any
 

robot/helper_invariant_service_thread_safety.py

@@ -17,7 +17,10 @@ if _SRC not in sys.path:
 from cleveragents.application.services.invariant_service import (  # noqa: E402
     InvariantService,
 )
-from cleveragents.domain.models.core.invariant import InvariantScope  # noqa: E402
+from cleveragents.domain.models.core.invariant import (  # noqa: E402
+    InvariantEnforcementRecord,
+    InvariantScope,
+)
 
 
 def _fresh_service() -> InvariantService:
@@ -174,7 +177,7 @@ def concurrent_enforce() -> None:
         )
 
     thread_count = 5
-    enforcement_records: list[object] = []
+    enforcement_records: list[InvariantEnforcementRecord] = []
     errors: list[Exception] = []
     lock = threading.Lock()
     invariants = svc.list_invariants()
@@ -207,7 +210,7 @@ def concurrent_enforce() -> None:
         )
         sys.exit(1)
 
-    decision_ids = [r.decision_id for r in enforcement_records]  # type: ignore[union-attr]
+    decision_ids = [r.decision_id for r in enforcement_records]
     unique_ids = set(decision_ids)
     if len(unique_ids) != len(decision_ids):
         print(

robot/helper_invariant_thread_safety_advanced.py

@@ -10,6 +10,7 @@ import contextlib
 import sys
 import threading
 import time
+from collections.abc import Callable
 from concurrent.futures import ThreadPoolExecutor, as_completed
 from pathlib import Path
 
@@ -373,7 +374,7 @@ def thread_safety_with_invariant_modifications() -> None:
     print("invariant-advanced-invariant-modifications-ok")
 
 
-COMMANDS: dict[str, callable] = {
+COMMANDS: dict[str, Callable[[], None]] = {
     "high-contention-add": high_contention_add,
     "lock-contention-stress": lock_contention_stress,
     "deadlock-prevention": deadlock_prevention,