fix(plans): remove #type:ignore and unreachable code from correction engine
CI / lint (pull_request) Failing after 47s
CI / typecheck (pull_request) Failing after 52s
CI / security (pull_request) Successful in 51s
CI / coverage (pull_request) Has been skipped
CI / benchmark-publish (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Has been skipped
CI / quality (pull_request) Successful in 40s
CI / build (pull_request) Successful in 27s
CI / unit_tests (pull_request) Failing after 45s
CI / docker (pull_request) Has been skipped
CI / integration_tests (pull_request) Failing after 51s

- Removed spurious # type: ignore[arg-type] at plan.py:792 — all argument types match (actor is str | None on both call and signature sides). Resolves PR review blocker #1.
- Removed dead/unreachable code in correction_service.py:execute_revert() — leftover append-mode implementation after early return statement. Fixes vulture security scan failure.

ISSUES CLOSED: #9562
This commit is contained in:
2026-05-17 20:39:59 +00:00
parent 8693590f88
commit 6f1471aea5
2 changed files with 1 additions and 10 deletions
@@ -223,15 +223,6 @@ class CorrectionService:
correction_id, request, result, attempt.attempt_id
)
return result
logger.info(
"correction.append_executed",
correction_id=correction_id,
status=result.status,
)
self._emit_correction_applied(
correction_id, request, result, attempt.attempt_id
)
return result
def execute_correction(self, correction_id: str,
decision_tree: dict[str, list[str]] | None = None,
+1 -1
View File
@@ -789,7 +789,7 @@ async def _tell_streaming(
description,
name,
actor=actor,
): # type: ignore[arg-type]
):
# Extract node name from event
for key in event:
if key != "__end__" and key in node_names: