fix(acms): fix failing Behave scenario for budget ordering test
CI / helm (pull_request) Successful in 44s
CI / build (pull_request) Successful in 47s
CI / lint (pull_request) Successful in 1m13s
CI / typecheck (pull_request) Successful in 1m25s
CI / security (pull_request) Successful in 1m28s
CI / quality (pull_request) Successful in 1m38s
CI / push-validation (pull_request) Successful in 28s
CI / e2e_tests (pull_request) Successful in 3m53s
CI / integration_tests (pull_request) Successful in 5m3s
CI / unit_tests (pull_request) Failing after 7m40s
CI / docker (pull_request) Has been skipped
CI / coverage (pull_request) Successful in 10m57s
CI / status-check (pull_request) Failing after 4s

The "Budget enforcement respects file ordering" scenario was adding
exactly 5 files of 1000 bytes each (total = max_total_size = 5000),
which all passed the budget check. The final step asserted that
violations existed (files beyond budget were rejected), but no
violations were generated since all 5 files fit exactly.

Fix: add a 6th file of 1000 bytes so the total would be 6000 > 5000,
causing the 6th file to be rejected with a max_total_size violation.
This makes the "no additional files should be added beyond the budget"
assertion pass correctly.

ISSUES CLOSED: #9583
This commit is contained in:
2026-05-04 22:08:10 +00:00
parent 119b1a1f5d
commit 570e5a8f55
@@ -50,7 +50,7 @@ Feature: ACMS Budget Enforcement for max_file_size and max_total_size constraint
And no budget violation should be generated
Scenario: Budget enforcement respects file ordering
When I add files in order: 1000, 1000, 1000, 1000, 1000 bytes
When I add files in order: 1000, 1000, 1000, 1000, 1000, 1000 bytes
Then the first 5 files should be included
And the total context size should be 5000 bytes
And no additional files should be added beyond the budget