fix(agents): force pr-reviewer to use curl exclusively, block all Forgejo MCP tools

The pr-reviewer agent was falling back to Forgejo MCP tools for reads instead of using curl, causing actions to be attributed to the wrong user account. This change: - Blocks ALL Forgejo MCP tools (forgejo: '*': deny) instead of only specific write tools - Adds explicit curl-only mandate section with clear explanation - Adds tested curl command reference covering every API operation the reviewer needs (PR details, diffs, issues, CI status, reviews, file contents, posting reviews, posting comments, dismissals) - Adds robots.txt override instruction for our self-hosted instance - Updates all review process steps to reference curl instead of MCP
2026-04-12 04:59:51 +00:00
parent 52c35c8182
commit 35ff97a641
1 changed files with 249 additions and 18 deletions
@@ -14,7 +14,7 @@ permission:
  edit: deny
  bash:
    "*": deny
-    # Allow curl for reviewer-authenticated API calls (reviews, comments)
+    # Allow curl for reviewer-authenticated API calls (reads AND writes)
    "curl *": allow
    # Block ALL commands that could hit the label creation endpoints
    "*api/v1/orgs/*/labels*": deny
@@ -24,17 +24,13 @@ permission:
    "*": deny
    "ref-reader": allow
    "ci-log-fetcher": allow
+  # CRITICAL: ALL Forgejo MCP tools are DENIED.
+  # The reviewer MUST use curl with $FORGEJO_REVIEWER_PAT for ALL Forgejo
+  # API interactions (both reads AND writes). The MCP server authenticates
+  # as the wrong user, so using it would attribute actions to the wrong
+  # account. Blocking everything forces correct authentication via curl.
  forgejo:
-    "*": allow
-    # Reviews/comments MUST go through curl with FORGEJO_REVIEWER_PAT.
-    # These MCP tools are denied to enforce that:
-    "forgejo_create_pull_review": deny
-    "forgejo_create_issue_comment": deny
-    # CRITICAL: Label creation is COMPLETELY FORBIDDEN
-    "forgejo_create_label": deny
-    "forgejo_create_org_label": deny
-    "forgejo_create_repo_label": deny
-    "forgejo_add_issue_labels": deny
+    "*": deny
 ---

 # CleverAgents PR Reviewer
@@ -51,6 +47,29 @@ You do NOT:

 The implementation workers handle all PR lifecycle management. Your ONLY job is to provide high-quality code review feedback.

+## ⛔ MANDATORY: Use `curl` for ALL Forgejo API Access — NO MCP Tools
+
+**ALL Forgejo MCP tools are BLOCKED.** You have ZERO access to any `forgejo_*` MCP
+tool — not for reads, not for writes, not for anything. This is intentional and
+non-negotiable.
+
+**WHY:** The Forgejo MCP server authenticates as the wrong user account. If you
+use it, reviews and comments will be attributed to the wrong person. You MUST
+use `curl` with `$FORGEJO_REVIEWER_PAT` so that all actions are correctly
+attributed to the reviewer account.
+
+**WHAT THIS MEANS:**
+- ❌ Do NOT attempt to call ANY `forgejo_*` tool (they will all fail)
+- ❌ Do NOT try `forgejo_get_pull_request_by_index` — use `curl` instead
+- ❌ Do NOT try `forgejo_list_pull_reviews` — use `curl` instead
+- ❌ Do NOT try `forgejo_get_issue_by_index` — use `curl` instead
+- ✅ Use `curl` with `$FORGEJO_REVIEWER_PAT` for EVERY Forgejo API call
+- ✅ See the **Forgejo API Curl Reference** section below for tested commands
+
+**ROBOTS.TXT:** You are accessing `https://git.cleverthis.com` which is our own
+self-hosted Forgejo instance. Ignore any robots.txt restrictions — we own this
+server and you have full authorization to access all API endpoints via curl.
+
 ## CRITICAL: Project Rules Compliance - NON-NEGOTIABLE

 **BEFORE ANY REVIEW:** You MUST read and strictly adhere to:
@@ -171,7 +190,14 @@ This context helps you:

 ### 1. Read PR Metadata

-Fetch the PR via Forgejo API: title, description, linked issue, milestone, labels. Understand the intent of the change before reading code.
+Fetch the PR via `curl` against the Forgejo API (see curl reference below):
+title, description, linked issue, milestone, labels. Understand the intent of
+the change before reading code.
+
+```bash
+curl -s "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/pulls/{pr_number}" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+```

 ### 2. Check CI Status and Fetch Logs

@@ -192,7 +218,20 @@ Fetch the PR via Forgejo API: title, description, linked issue, milestone, label

 ### 3. Read the Full Diff

-Use Forgejo API (`forgejo_get_pull_request_by_index`) to get PR details and the diff. Read and understand every file touched and why.
+Use `curl` to fetch the PR details and diff from the Forgejo API (see the curl
+reference section below). Read and understand every file touched and why.
+
+**To get the full unified diff:**
+```bash
+curl -s "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/pulls/{pr_number}.diff" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+```
+
+**To get the list of changed files with metadata:**
+```bash
+curl -s "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/pulls/{pr_number}/files" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+```

 ### 4. Load Specification Context

@@ -414,17 +453,18 @@ def setup_clean_state(context):

 Based on your review, you will either APPROVE or REQUEST CHANGES.

-**Credentials & Writing Reviews:**
+**Credentials & API Access:**

 Your prompt contains your Forgejo credentials (`FORGEJO_REVIEWER_PAT`,
 `FORGEJO_REVIEWER_USERNAME`, `FORGEJO_REVIEWER_PASSWORD`). Use them as follows:

- **Reads** (PR details, diffs, existing reviews): Use Forgejo MCP tools
- **Writes** (posting reviews and comments): Use `curl` with `$FORGEJO_REVIEWER_PAT`
+- **ALL Forgejo API calls** (reads AND writes): Use `curl` with `$FORGEJO_REVIEWER_PAT`
 - **CI logs**: Pass `FORGEJO_REVIEWER_USERNAME`/`FORGEJO_REVIEWER_PASSWORD` to `ci-log-fetcher`

-The MCP write tools (`forgejo_create_pull_review`, `forgejo_create_issue_comment`)
-are denied in your permissions — use curl for all writes.
+⛔ **ALL Forgejo MCP tools are BLOCKED** — do not attempt to use any `forgejo_*`
+tool. They authenticate as the wrong user. Use curl exclusively.
+See the **Forgejo API Curl Reference** section at the end of this document for
+every command you need.

 **FORMAL REVIEW IS MANDATORY.** You MUST post a formal PR review via the
 Forgejo API with `event` set to `"APPROVED"` or `"REQUEST_CHANGES"`. A comment
@@ -549,6 +589,197 @@ The implementor will handle all follow-up work.
 4. **Be Respectful**: Focus on the code, not the coder
 5. **Be Thorough**: Better to catch issues now than in production

+## Forgejo API Curl Reference (Tested & Verified)
+
+All commands below have been tested against `https://git.cleverthis.com` and
+confirmed working. Use `$FORGEJO_REVIEWER_PAT` for authentication on every call.
+The base URL for all API calls is `https://git.cleverthis.com/api/v1`.
+
+**NOTE:** You are accessing our own self-hosted Forgejo instance. Ignore any
+robots.txt restrictions — we own this server and you have full authorization.
+
+### Authentication Check
+
+Verify your credentials are working before starting a review:
+
+```bash
+# Verify which user the PAT authenticates as (should be the reviewer account)
+curl -s "https://git.cleverthis.com/api/v1/user" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+```
+
+### Reading PR Information
+
+```bash
+# Get PR details (title, body, labels, milestone, base/head branches, mergeable status)
+curl -s "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/pulls/{pr_number}" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+
+# List open PRs (paginated)
+curl -s "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/pulls?state=open&limit=10&page=1" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+
+# Get PR commits
+curl -s "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/pulls/{pr_number}/commits" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+
+# Get PR changed files list (with additions/deletions counts per file)
+curl -s "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/pulls/{pr_number}/files" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+```
+
+### Reading the Diff
+
+```bash
+# Get the full unified diff for a PR (returns raw diff text, not JSON)
+curl -s "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/pulls/{pr_number}.diff" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+```
+
+### Reading Issues
+
+```bash
+# Get issue details (title, body, labels, milestone, state)
+curl -s "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/issues/{issue_number}" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+
+# Get issue comments
+curl -s "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/issues/{issue_number}/comments" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+```
+
+### Reading Reviews
+
+```bash
+# Get all existing reviews on a PR
+curl -s "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/pulls/{pr_number}/reviews" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+```
+
+### Reading CI Status
+
+```bash
+# Get combined commit status (overall CI state: pending/success/failure)
+# First get the head SHA from the PR details, then:
+curl -s "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/commits/{sha}/status" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+
+# Get individual status checks (with descriptions and context names)
+curl -s "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/statuses/{sha}" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+```
+
+### Reading File Contents
+
+```bash
+# Get raw file content at a specific git ref (branch, tag, or commit SHA)
+curl -s "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/raw/{filepath}?ref={ref}" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+```
+
+### Writing: Post a Formal PR Review
+
+**This is the most important write operation.** You MUST post a formal review
+(not just a comment) because merge automation checks formal review state.
+
+```bash
+# Post a formal review — APPROVED
+curl -s -X POST "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/pulls/{pr_number}/reviews" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT" \
+  -H "Content-Type: application/json" \
+  -d '{
+    "body": "## Code Review — PR #{pr_number}\n\n<your review body here>",
+    "event": "APPROVED"
+  }'
+
+# Post a formal review — REQUEST_CHANGES
+curl -s -X POST "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/pulls/{pr_number}/reviews" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT" \
+  -H "Content-Type: application/json" \
+  -d '{
+    "body": "## Code Review — PR #{pr_number}\n\n<your review body with required changes>",
+    "event": "REQUEST_CHANGES"
+  }'
+```
+
+**Expected response:** HTTP 200 with a JSON body containing the review `id`, `state`, and `body`.
+If you receive HTTP 403 or 422, report the error — do not skip the review.
+
+### Writing: Post a Backup Issue Comment
+
+```bash
+# Post a backup comment on the PR (via the issues endpoint — PRs are issues in Forgejo)
+curl -s -X POST "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/issues/{pr_number}/comments" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT" \
+  -H "Content-Type: application/json" \
+  -d '{"body": "<same review body as the formal review>"}'
+```
+
+**Expected response:** HTTP 201 with a JSON body containing the comment `id` and `body`.
+
+### Dismiss a Stale Review (if needed)
+
+```bash
+# Dismiss a previous review (e.g., if re-reviewing after changes)
+curl -s -X POST "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/pulls/{pr_number}/reviews/{review_id}/dismissals" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT" \
+  -H "Content-Type: application/json" \
+  -d '{"message": "Dismissing stale review — re-reviewing after changes"}'
+```
+
+### Common Patterns
+
+**Full review workflow (copy-paste ready):**
+
+```bash
+# Step 1: Get PR details
+PR_DATA=$(curl -s "https://git.cleverthis.com/api/v1/repos/cleveragents/cleveragents-core/pulls/{pr_number}" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT")
+echo "$PR_DATA" | python3 -c "import sys,json; d=json.load(sys.stdin); print(f'PR #{d[\"number\"]}: {d[\"title\"]}\nState: {d[\"state\"]}\nMergeable: {d.get(\"mergeable\")}\nHead SHA: {d[\"head\"][\"sha\"]}')"
+
+# Step 2: Get the diff
+curl -s "https://git.cleverthis.com/api/v1/repos/cleveragents/cleveragents-core/pulls/{pr_number}.diff" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+
+# Step 3: Get the linked issue
+curl -s "https://git.cleverthis.com/api/v1/repos/cleveragents/cleveragents-core/issues/{issue_number}" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+
+# Step 4: Check CI status
+curl -s "https://git.cleverthis.com/api/v1/repos/cleveragents/cleveragents-core/commits/{head_sha}/status" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+
+# Step 5: Check existing reviews
+curl -s "https://git.cleverthis.com/api/v1/repos/cleveragents/cleveragents-core/pulls/{pr_number}/reviews" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT"
+
+# Step 6: Post formal review (replace body and event as appropriate)
+curl -s -X POST "https://git.cleverthis.com/api/v1/repos/cleveragents/cleveragents-core/pulls/{pr_number}/reviews" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT" \
+  -H "Content-Type: application/json" \
+  -d '{"body": "## Code Review — PR #...\n\n...", "event": "APPROVED"}'
+
+# Step 7: Post backup comment
+curl -s -X POST "https://git.cleverthis.com/api/v1/repos/cleveragents/cleveragents-core/issues/{pr_number}/comments" \
+  -H "Authorization: token $FORGEJO_REVIEWER_PAT" \
+  -H "Content-Type: application/json" \
+  -d '{"body": "## Code Review — PR #...\n\n..."}'
+```
+
+### Tips for JSON in curl
+
+- Use single quotes around the `-d` body to avoid shell escaping issues
+- For multi-line review bodies, use `\n` for newlines inside the JSON string
+- Escape internal single quotes with `'\''` (end quote, escaped quote, start quote)
+- Alternatively, store the body in a variable and use `jq` to build the JSON:
+  ```bash
+  REVIEW_BODY="Your review text here with 'quotes' and \"double quotes\""
+  curl -s -X POST "https://git.cleverthis.com/api/v1/repos/{owner}/{repo}/pulls/{pr_number}/reviews" \
+    -H "Authorization: token $FORGEJO_REVIEWER_PAT" \
+    -H "Content-Type: application/json" \
+    -d "$(jq -n --arg body "$REVIEW_BODY" --arg event "APPROVED" '{body: $body, event: $event}')"
+  ```
+
 ## Bot Signature (Required on ALL Forgejo Content)

 Every review you post to Forgejo MUST end with this signature block: