From 2dd920078a5a097f990411c7fe93edfcf5c325b9 Mon Sep 17 00:00:00 2001
From: CleverThis <hal9000@cleverthis.com>
Date: Thu, 28 May 2026 16:09:00 -0400
Subject: [PATCH] fix(tests): add resolve_actor_options to mock lifecycle
 helpers

The PR added resolve_actor_options() to StrategyActor, LLMStrategizeActor,
and LLMExecuteActor, but the three mock lifecycle SimpleNamespace objects
used by tests did not include this method, causing AttributeError at
runtime:

- features/mocks/mock_strategy_llm.py: make_mock_lifecycle() used by
  robot/helper_strategy_actor.py (strategy_actor.robot llm-json test)
  and features/steps/strategy_actor_llm_steps.py
- features/steps/llm_actors_coverage_steps.py: _make_mock_lifecycle()
  used by llm_actors_coverage.feature scenarios
- robot/helper_m5_e2e_context.py: inline lifecycle SimpleNamespace
  used by m5_e2e_verification.robot Execute Phase LLM Uses ACMS Context

All three now include resolve_actor_options=MagicMock(return_value=None)
matching the None-return contract the actors use when no custom backend
is configured.

ISSUES CLOSED: #11256
---
 features/mocks/mock_strategy_llm.py         | 1 +
 features/steps/llm_actors_coverage_steps.py | 1 +
 robot/helper_m5_e2e_context.py              | 1 +
 3 files changed, 3 insertions(+)

diff --git a/features/mocks/mock_strategy_llm.py b/features/mocks/mock_strategy_llm.py
index e3a91b1fc..308254390 100644
--- a/features/mocks/mock_strategy_llm.py
+++ b/features/mocks/mock_strategy_llm.py
@@ -321,6 +321,7 @@ def make_mock_lifecycle(
         get_plan=MagicMock(return_value=plan),
         get_action=MagicMock(return_value=action),
         resolve_actor_provider_model=MagicMock(return_value=None),
+        resolve_actor_options=MagicMock(return_value=None),
     )
 
 
diff --git a/features/steps/llm_actors_coverage_steps.py b/features/steps/llm_actors_coverage_steps.py
index 8142fdd45..9ac8d2ec1 100644
--- a/features/steps/llm_actors_coverage_steps.py
+++ b/features/steps/llm_actors_coverage_steps.py
@@ -93,6 +93,7 @@ def _make_mock_lifecycle(strategy_actor=None, execution_actor=None):
         get_plan=MagicMock(return_value=plan),
         get_action=MagicMock(return_value=action),
         resolve_actor_provider_model=MagicMock(return_value=None),
+        resolve_actor_options=MagicMock(return_value=None),
     )
     return lifecycle
 
diff --git a/robot/helper_m5_e2e_context.py b/robot/helper_m5_e2e_context.py
index 2e29b2079..b1cd2750f 100644
--- a/robot/helper_m5_e2e_context.py
+++ b/robot/helper_m5_e2e_context.py
@@ -476,6 +476,7 @@ def llm_execute_acms_context() -> None:
         get_plan=MagicMock(return_value=plan),
         get_action=MagicMock(return_value=action),
         resolve_actor_provider_model=MagicMock(return_value=None),
+        resolve_actor_options=MagicMock(return_value=None),
     )
 
     actor = LLMExecuteActor(