fix(cli): add scope parameter to compensating emit_config_changed() calls
CI / lint (pull_request) Failing after 1s
CI / quality (pull_request) Failing after 2s
CI / e2e_tests (pull_request) Failing after 2s
CI / build (pull_request) Failing after 2s
CI / helm (pull_request) Failing after 1s
CI / integration_tests (pull_request) Failing after 3m53s
CI / typecheck (pull_request) Successful in 4m14s
CI / coverage (pull_request) Has been skipped
CI / unit_tests (pull_request) Failing after 4m15s
CI / security (pull_request) Successful in 4m27s
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 1s
CI / benchmark-publish (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Has been skipped
CI / lint (pull_request) Failing after 1s
CI / quality (pull_request) Failing after 2s
CI / e2e_tests (pull_request) Failing after 2s
CI / build (pull_request) Failing after 2s
CI / helm (pull_request) Failing after 1s
CI / integration_tests (pull_request) Failing after 3m53s
CI / typecheck (pull_request) Successful in 4m14s
CI / coverage (pull_request) Has been skipped
CI / unit_tests (pull_request) Failing after 4m15s
CI / security (pull_request) Successful in 4m27s
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 1s
CI / benchmark-publish (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Has been skipped
Pass scope="global" to emit_config_changed() in the server_connect rollback path to maintain consistency with the scoped event details convention established by master's ConfigService.set_value(). ISSUES CLOSED: #993
This commit is contained in:
@@ -191,6 +191,7 @@ def server_connect(
|
||||
key=key,
|
||||
old_value=attempted_value,
|
||||
new_value=original_values.get(key),
|
||||
scope="global",
|
||||
compensating=True,
|
||||
reason="rollback_after_partial_server_connect_failure",
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user