fix(compiler): thread actor-level system_prompt into graph node metadata #7

Merged

hurui200320 merged 1 commit from fix/compiler-thread-system-prompt into master 2026-05-22 07:08:20 +00:00

Conversation 1 Commits 1 Files changed 5 +569 -4

hurui200320 commented 2026-05-22 03:54:00 +00:00

Member

Copy link

Summary

compile_actor() silently dropped the actor-level system_prompt field for type: graph actors. The CompiledActor contained no trace of it, forcing host applications to keep the raw ActorConfigSchema in scope as a workaround.

This fix applies three targeted additions across two files to close both the compilation gap and the runtime context gap.

Motivation

docs/reference/actors_schema.md explicitly documents system_prompt as "Default prompt for graph-level agents" — placing it in the same semantic category as provider and model: actor-level fields that serve as fallback defaults for all AGENT nodes. The compiler already threaded provider and model via setdefault; system_prompt was simply never added to the same pattern.

A second independent gap in Node._execute_agent() meant that even after fixing the compiler, the system_prompt value would not appear in the context dict passed to agent.process_message().

Changes

src/cleveractors/actor/compiler.py

• _map_node() gains an actor_system_prompt: str | None = None parameter.
• merged_meta.setdefault("system_prompt", actor_system_prompt) is applied inside the if node.type == NodeType.AGENT: block, after the existing provider/model calls. setdefault preserves any per-node override in config.system_prompt.
• Post-review fix: The key is only set when actor_system_prompt is not None, so actors without a top-level system_prompt don't carry a "system_prompt": None entry in every AGENT node's metadata.
• compile_actor() passes actor_system_prompt=config.system_prompt to _map_node().

src/cleveractors/langgraph/nodes.py

• Node._execute_agent() extracts node_system_prompt from self.config.metadata.get("system_prompt") and injects it into the context dict before state.metadata is merged. This allows host agents to read context.get("system_prompt") without a direct reference to the raw ActorConfigSchema. Per-execution state.metadata["system_prompt"] overrides still take precedence.
• Post-review fix: A defensive isinstance(raw, str) guard rejects non-string values (e.g. integer, list) that could be injected via manually constructed NodeConfig.
• Post-review fix: "system_prompt" is added to ignore_keys to prevent agents from mutating it in the context dict and accidentally persisting the mutation into metadata_updates.

docs/reference/actor_compiler.md

• Node Binding table updated: AGENT row now references a detailed "AGENT node defaults" subsection describing the system_prompt threading behavior.

features/compiler_system_prompt.feature + features/steps/compiler_system_prompt_steps.py

Ten BDD scenarios covering the full behavioral surface:

1. Actor-level system_prompt is threaded into each AGENT node's NodeConfig.metadata.
2. Per-node config.system_prompt takes precedence over the actor-level default (setdefault semantics).
3. agent.process_message() receives system_prompt in its context dict.
4. state.metadata["system_prompt"] overrides the compiled default at runtime.
5. state.metadata["system_prompt"] = None overrides a compiled default (clearing the prompt).
6. Empty-string system_prompt is threaded into AGENT node metadata.
7. Empty-string system_prompt is passed into the runtime context dict.
8. Non-AGENT nodes (TOOL, CONDITIONAL, SUBGRAPH) do not receive system_prompt in compiled metadata.
9. Actor without system_prompt does not add the key to AGENT node metadata (post-review: was "set to None").
10. Absent system_prompt is excluded from the runtime context dict.

Post-review additions

Step-definition file reorganized into functional sections (compilation assertions, runtime assertions). "Each AGENT node" step definitions include a guard against zero-AGENT-node graphs.

Quality Gates

Gate	Result
nox -s lint	✅ pass (0 issues)
nox -s typecheck	✅ pass (0 errors, 0 warnings)
nox -s unit_tests	✅ pass (17/17 scenarios)
nox -s coverage_report	✅ pass (≥ 97%)
nox -s security_scan	✅ pass (0 findings)
nox -s dead_code	✅ pass
nox -s complexity	✅ pass (avg complexity A)

Closes #6

## Summary `compile_actor()` silently dropped the actor-level `system_prompt` field for `type: graph` actors. The `CompiledActor` contained no trace of it, forcing host applications to keep the raw `ActorConfigSchema` in scope as a workaround. This fix applies three targeted additions across two files to close both the compilation gap and the runtime context gap. ## Motivation `docs/reference/actors_schema.md` explicitly documents `system_prompt` as _"Default prompt for graph-level agents"_ — placing it in the same semantic category as `provider` and `model`: actor-level fields that serve as fallback defaults for all AGENT nodes. The compiler already threaded `provider` and `model` via `setdefault`; `system_prompt` was simply never added to the same pattern. A second independent gap in `Node._execute_agent()` meant that even after fixing the compiler, the `system_prompt` value would not appear in the context dict passed to `agent.process_message()`. ## Changes ### `src/cleveractors/actor/compiler.py` - `_map_node()` gains an `actor_system_prompt: str | None = None` parameter. - `merged_meta.setdefault("system_prompt", actor_system_prompt)` is applied inside the `if node.type == NodeType.AGENT:` block, after the existing `provider`/`model` calls. `setdefault` preserves any per-node override in `config.system_prompt`. - **Post-review fix:** The key is only set when `actor_system_prompt is not None`, so actors without a top-level `system_prompt` don't carry a `"system_prompt": None` entry in every AGENT node's metadata. - `compile_actor()` passes `actor_system_prompt=config.system_prompt` to `_map_node()`. ### `src/cleveractors/langgraph/nodes.py` - `Node._execute_agent()` extracts `node_system_prompt` from `self.config.metadata.get("system_prompt")` and injects it into the context dict **before** `state.metadata` is merged. This allows host agents to read `context.get("system_prompt")` without a direct reference to the raw `ActorConfigSchema`. Per-execution `state.metadata["system_prompt"]` overrides still take precedence. - **Post-review fix:** A defensive `isinstance(raw, str)` guard rejects non-string values (e.g. integer, list) that could be injected via manually constructed `NodeConfig`. - **Post-review fix:** `"system_prompt"` is added to `ignore_keys` to prevent agents from mutating it in the context dict and accidentally persisting the mutation into `metadata_updates`. ### `docs/reference/actor_compiler.md` - Node Binding table updated: `AGENT` row now references a detailed "AGENT node defaults" subsection describing the `system_prompt` threading behavior. ### `features/compiler_system_prompt.feature` + `features/steps/compiler_system_prompt_steps.py` Ten BDD scenarios covering the full behavioral surface: 1. Actor-level `system_prompt` is threaded into each AGENT node's `NodeConfig.metadata`. 2. Per-node `config.system_prompt` takes precedence over the actor-level default (setdefault semantics). 3. `agent.process_message()` receives `system_prompt` in its context dict. 4. `state.metadata["system_prompt"]` overrides the compiled default at runtime. 5. `state.metadata["system_prompt"] = None` overrides a compiled default (clearing the prompt). 6. Empty-string `system_prompt` is threaded into AGENT node metadata. 7. Empty-string `system_prompt` is passed into the runtime context dict. 8. Non-AGENT nodes (TOOL, CONDITIONAL, SUBGRAPH) do **not** receive `system_prompt` in compiled metadata. 9. Actor without `system_prompt` does **not** add the key to AGENT node metadata (post-review: was "set to None"). 10. Absent `system_prompt` is excluded from the runtime context dict. ### Post-review additions Step-definition file reorganized into functional sections (compilation assertions, runtime assertions). "Each AGENT node" step definitions include a guard against zero-AGENT-node graphs. ## Quality Gates | Gate | Result | |------|--------| | `nox -s lint` | ✅ pass (0 issues) | | `nox -s typecheck` | ✅ pass (0 errors, 0 warnings) | | `nox -s unit_tests` | ✅ pass (17/17 scenarios) | | `nox -s coverage_report` | ✅ pass (≥ 97%) | | `nox -s security_scan` | ✅ pass (0 findings) | | `nox -s dead_code` | ✅ pass | | `nox -s complexity` | ✅ pass (avg complexity A) | Closes #6

hurui200320 added the

Type

Bug

label 2026-05-22 03:54:07 +00:00

hurui200320 added a new dependency 2026-05-22 03:56:22 +00:00

#6 compile_actor() drops graph-level system_prompt — not threaded into CompiledActor

hurui200320 force-pushed fix/compiler-thread-system-prompt from f4155e489d to a18e8c5931 2026-05-22 03:57:32 +00:00 Compare

hurui200320 force-pushed fix/compiler-thread-system-prompt from a18e8c5931 to bc01753113 2026-05-22 04:30:06 +00:00 Compare

hurui200320 force-pushed fix/compiler-thread-system-prompt from bc01753113 to 5aeadcc0aa 2026-05-22 05:18:18 +00:00 Compare

hurui200320 force-pushed fix/compiler-thread-system-prompt from 5aeadcc0aa to 61c8a6f48f 2026-05-22 05:22:23 +00:00 Compare

hurui200320 force-pushed fix/compiler-thread-system-prompt from 61c8a6f48f to dd6c20df5d 2026-05-22 06:05:27 +00:00 Compare

hurui200320 commented 2026-05-22 07:00:12 +00:00

Author

Member

Copy link

Self-QA Review — Approved ✅

Ran 2 review/fix cycles. The PR is ready to merge.

Cycle 1 — Request Changes (0C / 3M / 5m / 2n)

All issues were addressed in the same cycle:

#	Severity	Issue	Fix
M1	Major	No test for empty-string system_prompt (compiler + runtime)	2 new BDD scenarios added
M2	Major	No test for state.metadata = {"system_prompt": None} runtime override	1 new BDD scenario added
M3	Major	CONDITIONAL and SUBGRAPH types untested (only TOOL was covered)	Mixed-graph scenario extended
m1	Minor	setdefault(None) unconditionally polluted AGENT node metadata shape	Guarded with if actor_system_prompt is not None:
m2	Minor	metadata.get() returned Any; no runtime type guard	Replaced with isinstance(node_system_prompt, str)
m3	Minor	system_prompt absent from ignore_keys — agent mutations leaked to state	Added "system_prompt" to ignore_keys
m4	Minor	# Then steps for new scenarios was a drafting artifact	Reorganized into functional sections
m5	Minor	"each AGENT node" loops tautologically passed on empty graphs	agent_nodes_found > 0 guard added
n1	Nit	AGENT doc table row was too dense	De-densified + new subsection added

After fixes: 17/17 scenarios, all 7 quality gates ✅

Cycle 2 — Approve (0C / 0M / 3m / 3n)

No further fixes applied. Remaining items are non-blocking:

#	Severity	Issue
m1	Minor	No test for non-string non-None system_prompt in node metadata
m2	Minor	No explicit test that ignore_keys exclusion works
m3	Minor	No scenario for actor-None + per-node system_prompt override combination
n1	Nit	Commit message body references stale scenario counts and guard semantics
n2	Nit	_CapturingAgent uses shallow dict() copy instead of deepcopy
n3	Nit	Gherkin step pattern fragile for quoted "None" edge case

These can be addressed in a follow-up ticket if desired.

Quality Gates (final)

Gate	Status
nox -s lint	✅ Pass
nox -s typecheck	✅ Pass (0 errors)
nox -s unit_tests	✅ Pass (17/17)
nox -s coverage_report	✅ Pass (≥ 97%)
nox -s security_scan	✅ Pass (0 findings)
nox -s dead_code	✅ Pass
nox -s complexity	✅ Pass (avg A)

## Self-QA Review — Approved ✅ Ran 2 review/fix cycles. The PR is ready to merge. ### Cycle 1 — Request Changes (0C / 3M / 5m / 2n) All issues were addressed in the same cycle: | # | Severity | Issue | Fix | |---|----------|-------|-----| | M1 | Major | No test for empty-string `system_prompt` (compiler + runtime) | 2 new BDD scenarios added | | M2 | Major | No test for `state.metadata = {"system_prompt": None}` runtime override | 1 new BDD scenario added | | M3 | Major | CONDITIONAL and SUBGRAPH types untested (only TOOL was covered) | Mixed-graph scenario extended | | m1 | Minor | `setdefault(None)` unconditionally polluted AGENT node metadata shape | Guarded with `if actor_system_prompt is not None:` | | m2 | Minor | `metadata.get()` returned `Any`; no runtime type guard | Replaced with `isinstance(node_system_prompt, str)` | | m3 | Minor | `system_prompt` absent from `ignore_keys` — agent mutations leaked to state | Added `"system_prompt"` to `ignore_keys` | | m4 | Minor | `# Then steps for new scenarios` was a drafting artifact | Reorganized into functional sections | | m5 | Minor | "each AGENT node" loops tautologically passed on empty graphs | `agent_nodes_found > 0` guard added | | n1 | Nit | AGENT doc table row was too dense | De-densified + new subsection added | After fixes: **17/17 scenarios**, all 7 quality gates ✅ ### Cycle 2 — Approve (0C / 0M / 3m / 3n) No further fixes applied. Remaining items are non-blocking: | # | Severity | Issue | |---|----------|-------| | m1 | Minor | No test for non-string non-None `system_prompt` in node metadata | | m2 | Minor | No explicit test that `ignore_keys` exclusion works | | m3 | Minor | No scenario for actor-None + per-node `system_prompt` override combination | | n1 | Nit | Commit message body references stale scenario counts and guard semantics | | n2 | Nit | `_CapturingAgent` uses shallow `dict()` copy instead of `deepcopy` | | n3 | Nit | Gherkin step pattern fragile for quoted `"None"` edge case | These can be addressed in a follow-up ticket if desired. ### Quality Gates (final) | Gate | Status | |------|--------| | `nox -s lint` | ✅ Pass | | `nox -s typecheck` | ✅ Pass (0 errors) | | `nox -s unit_tests` | ✅ Pass (17/17) | | `nox -s coverage_report` | ✅ Pass (≥ 97%) | | `nox -s security_scan` | ✅ Pass (0 findings) | | `nox -s dead_code` | ✅ Pass | | `nox -s complexity` | ✅ Pass (avg A) |

hurui200320 merged commit dd6c20df5d into master 2026-05-22 07:08:20 +00:00

hurui200320 deleted branch fix/compiler-thread-system-prompt 2026-05-22 07:08:20 +00:00

CoreRasurae referenced this pull request 2026-06-08 23:13:51 +00:00

feat(registry): extend TemplateType and integrate PackageReference into template system #35

CoreRasurae referenced this pull request 2026-06-09 10:36:52 +00:00

feat(registry): extend TemplateType and integrate PackageReference into template system #35

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#6 compile_actor() drops graph-level system_prompt — not threaded into CompiledActor

cleveragents/cleveractors-core

Reference

cleveragents/cleveractors-core!7

No description provided.