2 Commits

Author	SHA1	Message	Date
hurui200320	76c4c74201	feat(create_executor): implement create_executor() factory and Executor.execute() returning ActorResult ... - **`src/cleveractors/runtime_types.py`** — `ActorResult` and `NodeUsage` dataclasses extracted to break circular imports (CONTRIBUTING.md §Import Guidelines). 100% coverage. - **`src/cleveractors/runtime.py`** — `create_executor()` factory, `Executor` class with `execute()` dispatching to module-level functions in `runtime_dispatch`. Imports `_execute_*` at module level (no function-local imports). 100% coverage. - **`src/cleveractors/runtime_dispatch.py`** — Four dispatch functions: `_execute_llm`, `_execute_graph`, `_execute_tool`, `_execute_multi_actor`. All imports at module level except `from cleveractors.runtime import Executor` inside `_execute_multi_actor` (the only remaining circular dep — Executor calls _execute_multi_actor which creates a new Executor; cannot be resolved without further restructuring). 99.69% coverage (only the `if TYPE_CHECKING:` guard line is uncovered — not a real gap). - **`src/cleveractors/runtime_tokens.py`** — Token estimation via tiktoken with heuristic fallback. 100% coverage. Key design decisions and fixes: - **Circular import resolution**: `ActorResult`/`NodeUsage` moved to `runtime_types.py`; both `runtime.py` and `runtime_dispatch.py` import from it at module level. - **`messages` forwarded to `_execute_llm`**: builds `context={"conversation_history":[...]}` passed to `LLMAgent.process_message` for multi-turn support. - **`parallel_execution` aligned with `PureGraphConfig` default (True)**: reads from legacy `route` dict or v2.0 `routes.main` dict; defaults to True. - **Factory normalization**: always merges `actors` into `agents` (actors take precedence) so configs using both keys work correctly. - **Generic exception in agent creation re-raised as `ConfigurationError`**: no double-logging; exception message preserved in `ConfigurationError`. - **`cleveragents_block` guarded against `None`**: uses `or {}` coercion. - **Type annotations added**: `top_provider`, `top_model`, `top_sp`, `temperature_raw`, `max_tokens_raw`, `config_block`, `tools` in dispatch functions. - **No `finally` in `_execute_tool`**: documented with comment (ToolAgent has no cleanup). - **Dead step removed**: `step_rxe_invalid_node_type` was unreferenced and incorrect. - **BDD coverage**: `parallel_execution=False` override verified via `PureGraphConfig` constructor args; conversation history forwarding verified; AC7 immutability for multi-actor path verified. - ✅ `nox -e lint` — passes - ✅ `nox -e format` — passes - ✅ `nox -e typecheck` — passes (0 errors, 1 expected warning) - ✅ `nox -e unit_tests` — 2113 scenarios pass, 0 failures, 0 skipped - ✅ `nox -e integration_tests` — 76 tests pass - ✅ `nox -e coverage_report` — 97.21% (9870 covered, 283 missing, 10153 total) PR-modified files: `runtime_types.py` 100%, `runtime.py` 100%, `runtime_dispatch.py` 99.69% (1 uncoverable TYPE_CHECKING guard), `runtime_tokens.py` 100% ISSUES CLOSED: #13	2026-06-10 09:41:39 +00:00
CoreRasurae	3fc0a3fa57	test(coverage): add BDD unit tests to close coverage gap toward 97% ... Add comprehensive BDD Behave unit tests across six modules to improve line coverage. New feature files and step definitions for: - validation/_actor: graph/llm/tool/multi_actor config validation - runtime_tokens: token estimation with tiktoken and fallback heuristics - dynamic_router: ContentBasedCondition, RouterNode, graph extension - runtime: v2 route format, config blocks, conversation history, multi-actor - progress: ProgressBarManager remaining count resolution - route: MESSAGE_ROUTER rules to metadata in to_graph_config Also fix credential executor and graph cleanup step mocks to return proper tuple values matching updated runtime signatures. Refs: #39	2026-06-09 16:06:32 +01:00