59 lines
2.5 KiB
TypeScript
59 lines
2.5 KiB
TypeScript
const r = require("https");
|
|
const p = JSON.stringify({body: `
|
|
## PR Review Summary
|
|
|
|
### Reviewer: HAL9001 (Automated Bot)
|
|
### Verdict: REQUEST_CHANGES
|
|
|
|
---
|
|
|
|
## Changes Verified: CORRECT ✅
|
|
|
|
**1. Trigger Names** — The PR correctly updates trigger names from `on_tool_write` / `on_tool_write_complete` to `before_tool_execute` / `after_tool_execute` to match the actual implementation in:
|
|
- `${src}/cleverrouter/tool/runner.py` — Uses `before_tool_execute` and `after_tool_execute` in the `ToolRunner.execute()` method
|
|
- `${src}/cleverrouter/application/services/config_service.py` — Registers valid triggers including these two
|
|
|
|
**2. Configuration Format** — Converting TOML examples from array format `["on_tool_write", "on_tool_write_complete"]` to comma-separated string format `"before_tool_execute,after_tool_execute,on_subplan_spawn,on_error"` is correct per the ConfigService implementation.
|
|
|
|
---
|
|
|
|
## Changes Verified: INCORRECT ❌
|
|
|
|
**1. Config Key Path — MAJOR ISSUE**
|
|
|
|
The PR changes the documented config path from:
|
|
- **OLD (correct)**: `core.checkpoints.auto_create_on`
|
|
- **PR version (wrong)**: `checkpoints.auto_create_on`
|
|
|
|
The actual implementation in `config_service.py` registers this at:
|
|
```
|
|
_register("core", "checkpoints.auto_create_on", str, ...)
|
|
```
|
|
|
|
Which means the full configuration path is **`core.checkpoints.auto_create_on`**, not `checkpoints.auto_create_on`.
|
|
|
|
The PR made the documentation **less aligned** with reality for this field.
|
|
|
|
**Expected TOML:**
|
|
```toml
|
|
[core]
|
|
[core.checkpoints]
|
|
auto_create_on = "before_tool_execute,after_tool_execute,on_subplan_spawn,on_error"
|
|
```
|
|
|
|
---
|
|
|
|
## Notes
|
|
|
|
- **on_subplan_spawn**: Listed in both docs and default config, but **not implemented** in `PlanExecutor` or `SubplanExecutionService`. A missing feature, not a docs bug.
|
|
- **CI Failure**: Pre-existing e2e failure unrelated to this docs-only change.
|
|
- **Issue Reference**: PR body doesn't contain "Closes #10826"
|
|
|
|
---
|
|
Automated by CleverAgents Bot`,
|
|
body: "Review comment"});
|
|
const o = {hostname: "git.cleverthis.com", port: 443, path: "/api/v1/repos/cleverrouter/cleverrouter-core/issues/10865/comments", method: "POST", headers: {"Authorization": "token 060faa5ff13338d510ef808027b6314a2e895c3d", "Content-Type": "application/json", "Content-Length": Buffer.byteLength(p)}};
|
|
const req = r.request(o, (res) => { let d = ""; res.on("data", (c) => d += c); res.on("end", () => { console.log(res.statusCode, d.substring(0, 300)); }); });
|
|
req.on("error", (e) => console.error(e.message));
|
|
req.write(p); req.end();
|