forked from HAL9000/cleveragents-core
Brent E. Edwards
5e625b22e1
Replace CliRunner + unittest.mock.patch with subprocess.run for all 21 CLI-facing test functions across the M1-M6 E2E verification helpers. Application code fixes: - action.py: _get_lifecycle_service() uses container.plan_lifecycle_service() - plan.py: _get_lifecycle_service() uses container.plan_lifecycle_service() - plan.py: three container.resolve(DecisionService) → container.decision_service() Test infrastructure: - New robot/helper_e2e_common.py with shared subprocess utilities (run_cli, setup_workspace with DB migrations, cleanup_workspace) - M1-M4, M6 helpers refactored to use run_cli() with real SQLite DB - M5 unchanged (0 CLI tests, all domain-level) - TDD detection updated to recognise run_cli() as subprocess invocation - Remove @tdd_expected_fail from TDD feature + robot tags - Update 8 Behave step files that mocked container.resolve() to use container.decision_service() / container.plan_lifecycle_service()
63 lines
2.2 KiB
Python
63 lines
2.2 KiB
Python
"""Step definitions for additional action CLI coverage."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from types import SimpleNamespace
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from behave import given, then, when
|
|
|
|
from cleveragents.application.services.plan_lifecycle_service import (
|
|
PlanLifecycleService,
|
|
)
|
|
from cleveragents.cli.commands.action import _get_lifecycle_service
|
|
|
|
|
|
@given("a mocked container settings for action lifecycle")
|
|
def step_mock_container_settings(context) -> None:
|
|
"""Mock container to resolve lifecycle service via plan_lifecycle_service()."""
|
|
context.settings = MagicMock()
|
|
|
|
def _make_service() -> PlanLifecycleService:
|
|
return PlanLifecycleService(settings=context.settings)
|
|
|
|
container = SimpleNamespace(plan_lifecycle_service=_make_service)
|
|
patcher = patch(
|
|
"cleveragents.cli.commands.action.get_container",
|
|
return_value=container,
|
|
)
|
|
patcher.start()
|
|
context.container_patcher = patcher
|
|
if not hasattr(context, "_cleanup_handlers"):
|
|
context._cleanup_handlers = []
|
|
context._cleanup_handlers.append(patcher.stop)
|
|
|
|
|
|
@when("I resolve the action lifecycle service")
|
|
def step_resolve_lifecycle_service(context) -> None:
|
|
"""Call the lifecycle service helper."""
|
|
context.lifecycle_service = _get_lifecycle_service()
|
|
|
|
|
|
@when("I resolve the action lifecycle service twice")
|
|
def step_resolve_lifecycle_service_twice(context) -> None:
|
|
"""Call the lifecycle service helper twice."""
|
|
context.lifecycle_services = [_get_lifecycle_service(), _get_lifecycle_service()]
|
|
|
|
|
|
@then("the lifecycle service should use container settings")
|
|
def step_assert_lifecycle_service_settings(context) -> None:
|
|
"""Verify the lifecycle service uses the mocked settings."""
|
|
services = getattr(context, "lifecycle_services", None)
|
|
if services is None:
|
|
services = [context.lifecycle_service]
|
|
for service in services:
|
|
assert isinstance(service, PlanLifecycleService)
|
|
assert service.settings is context.settings
|
|
|
|
|
|
@then("the lifecycle service instances should be distinct")
|
|
def step_assert_lifecycle_service_distinct(context) -> None:
|
|
"""Verify each lifecycle service instance is unique."""
|
|
assert context.lifecycle_services[0] is not context.lifecycle_services[1]
|