2 Commits

Author	SHA1	Message	Date
freemo	a0df5a4cd0	fix(cli): wrap format_output() in spec-required JSON/YAML envelope across all CLI commands ... Implements the spec-required JSON/YAML output envelope for all CLI commands that use format_output(). The envelope structure is: { "command": "<command that was run>", "status": "ok" | "warn" | "error", "exit_code": 0, "data": { ... command-specific payload ... }, "timing": { "duration_ms": 123 }, "messages": [{ "level": "ok", "text": "..." }] } Changes: - Add _build_envelope() helper to construct the spec-required envelope - Add optional command, status, exit_code, messages parameters to format_output() - Wrap json/yaml output in the envelope; plain/table/rich/color unchanged - Add timing measurement (duration_ms) to all json/yaml outputs - Add new BDD feature file (cli_json_envelope.feature) with 14 scenarios testing envelope field presence, values, and data payload - Update 14 existing step files to unwrap the envelope when checking specific data keys (backward-compatible via _unwrap_envelope() helper) Closes #3431	2026-04-05 19:48:40 +00:00
freemo	c9abb45adf	test(coverage): add Behave BDD scenarios for 9 under-covered modules ... Added 246 new BDD scenarios across 9 feature files to improve unit test coverage for modules that were either entirely untested or had significant coverage gaps: - lock_service_coverage.feature (27 scenarios): validation branches, TTL boundaries, re-entrant acquisition, rollback on exceptions - plan_apply_service_coverage.feature (54 scenarios): operation labels, diff rendering (plain/rich/json), artifact building, validation gate, changeset resolution and cleanup - plan_executor_coverage.feature (51 scenarios): step parsing, execute actor integration, strategize/execute guards, stub retry/recovery, decision tree construction - skill_cli_coverage_r3.feature (22 scenarios): tools refresh, list/show JSON fallback, capability summary errors, remove confirmation - changeset_repository_coverage.feature (39 scenarios): entry/tool repos validation, database error wrapping, domain conversion, SQLite store CRUD operations - repositories_coverage.feature (20 scenarios): get_by_name/namespace errors, list_available filters, delete with ActionInUseError, plan update with invariants/processing_state/error_details - sandbox_copy_on_write_coverage.feature (12 scenarios): create OSError wrapping, get_path state transitions, commit edge cases, rollback errors, cleanup with missing paths - bridge_coverage.feature (8 scenarios): __del__ suppression, async task cancellation, execute_graph message type handling, stream config, state checkpointer - plan_cli_coverage.feature (13 scenarios): legacy apply/list/cd paths, use-action with estimation/invariant actors, lifecycle-apply guards, status errors, error recovery display All 246 scenarios (1105 steps) pass. Step definitions use unique prefixes to prevent ambiguous step conflicts with existing tests. ISSUES CLOSED: #467	2026-02-27 13:47:42 -05:00