Commit Graph

4 Commits

Author SHA1 Message Date
freemo 8ea00f5185 fix: restore CI quality tests to passing state (#4175)
Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>
Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>
2026-04-08 11:02:14 +00:00
freemo 56f424714c fix(tdd): replace non-standard @tdd_bug tags with @tdd_issue per CONTRIBUTING.md
Audit all feature files for non-compliant @tdd_bug tag usage and replace
with the CONTRIBUTING.md-specified @tdd_issue / @tdd_issue_<N> tags.

Three files were affected:

- features/tdd_actor_list_no_db_update.feature:
  @tdd_bug @tdd_bug_797 → @tdd_issue @tdd_issue_797
  (bug #797 is fixed; permanent regression guard, no @tdd_expected_fail)

- features/tdd_exec_env_resolution_precedence.feature:
  Removed duplicate @tdd_bug @tdd_bug_1080 tags; file already had the
  correct @tdd_issue @tdd_issue_1080 tags.

- features/tdd_use_action_automation_profile.feature:
  @tdd_bug @tdd_bug_1076 → @tdd_issue @tdd_issue_1076
  (bug #1076 is fixed in upstream; @tdd_expected_fail not needed)

Zero occurrences of @tdd_bug or @tdd_bug_<N> remain in features/.
All nox quality gates pass: lint   unit_tests  (14426 scenarios passed).

ISSUES CLOSED: #2779
2026-04-05 09:09:06 +00:00
brent.edwards 3fa07fb772 test: align #1080 expected-fail tags with TDD schema
Add @tdd_issue and @tdd_issue_1080 so the expected-fail scenario passes the global tag validator during unit_tests.
2026-03-27 22:53:33 +00:00
brent.edwards 5ac1e4eeb3 test: add TDD bug-capture test for #1080 — execution env resolution precedence
Write a Behave feature (features/tdd_exec_env_resolution_precedence.feature)
with three scenarios that capture bug #1080: the ExecutionEnvironmentResolver
does not honour the 6-level execution environment precedence chain defined in
the spec (§Execution Environment Routing).

The critical scenario ("Project-level override beats plan-level fallback")
demonstrates the bug by calling resolve() with plan_env="host" and
project_env="container", where the project has priority "override" and the
plan has priority "fallback".  Per the spec, project override (level 2)
should beat plan fallback (level 4), but the current flat resolver chain
returns "host" (plan always wins).  The @tdd_expected_fail tag inverts
this assertion failure to a CI pass.

Two regression-guard scenarios (without @tdd_expected_fail) verify:
(1) Plan-level override still beats project-level override (level 1 vs 2).
(2) Project-level override beats host default (level 2 vs 6).
Both pass both competing environments to the resolver to ensure the
resolver sees the full context and must choose correctly.

Files added:
- features/tdd_exec_env_resolution_precedence.feature — tagged with
  @tdd_bug @tdd_bug_1080 @mock_only and one @tdd_expected_fail scenario
- features/steps/tdd_exec_env_resolution_precedence_steps.py — step
  definitions with priority validation, TODO markers for #1080 cleanup,
  and module-level imports

Robot test: N/A — ExecutionEnvironmentResolver is a pure domain service
with no I/O or integration boundaries.

ISSUES CLOSED: #1101
2026-03-27 22:53:33 +00:00