forked from cleveragents/cleveragents-core
freemo
0d4a47f3c0
- Fix Settings.database_url default from relative 'sqlite:///cleveragents.db' to absolute 'sqlite:////home/<user>/.cleveragents/cleveragents.db' using Path.home() / '.cleveragents' / 'cleveragents.db' - Fix test_database_url default similarly to use ~/.cleveragents/cleveragents_test.db - Fix alembic/env.py fallback default from Path.cwd() / '.cleveragents' / 'db.sqlite' to Path.home() / '.cleveragents' / 'cleveragents.db' (matching Settings) - Both Settings and alembic/env.py now resolve to the same absolute path - CLEVERAGENTS_DATABASE_URL env var override still works correctly in both - Update coverage_boost_steps.py assertions to match new correct defaults - Add 3 new Behave scenarios covering correct database_url default and env var override ISSUES CLOSED: #2871
103 lines
3.3 KiB
Python
103 lines
3.3 KiB
Python
import os
|
|
from logging.config import fileConfig
|
|
from pathlib import Path
|
|
|
|
from alembic import context
|
|
from sqlalchemy import engine_from_config, pool
|
|
|
|
# Import our models
|
|
from cleveragents.infrastructure.database.models import Base
|
|
|
|
# this is the Alembic Config object, which provides
|
|
# access to the values within the .ini file in use.
|
|
config = context.config
|
|
|
|
# Interpret the config file for Python logging.
|
|
# This line sets up loggers basically.
|
|
# NOTE: disable_existing_loggers=False prevents fileConfig from disabling
|
|
# application loggers that were created before this point, which causes
|
|
# test failures when log capture handlers are attached to those loggers.
|
|
if config.config_file_name is not None:
|
|
fileConfig(config.config_file_name, disable_existing_loggers=False)
|
|
|
|
# add your model's MetaData object here
|
|
# for 'autogenerate' support
|
|
target_metadata = Base.metadata
|
|
|
|
# Override the database URL from environment or use default
|
|
# This allows flexible configuration based on deployment
|
|
# Default matches Settings.database_url: ~/.cleveragents/cleveragents.db
|
|
database_url = os.getenv(
|
|
"CLEVERAGENTS_DATABASE_URL",
|
|
f"sqlite:///{Path.home() / '.cleveragents' / 'cleveragents.db'}",
|
|
)
|
|
config.set_main_option("sqlalchemy.url", database_url)
|
|
|
|
# other values from the config, defined by the needs of env.py,
|
|
# can be acquired:
|
|
# my_important_option = config.get_main_option("my_important_option")
|
|
# ... etc.
|
|
|
|
|
|
def run_migrations_offline() -> None:
|
|
"""Run migrations in 'offline' mode.
|
|
|
|
This configures the context with just a URL
|
|
and not an Engine, though an Engine is acceptable
|
|
here as well. By skipping the Engine creation
|
|
we don't even need a DBAPI to be available.
|
|
|
|
Calls to context.execute() here emit the given string to the
|
|
script output.
|
|
|
|
"""
|
|
url = config.get_main_option("sqlalchemy.url")
|
|
context.configure(
|
|
url=url,
|
|
target_metadata=target_metadata,
|
|
literal_binds=True,
|
|
dialect_opts={"paramstyle": "named"},
|
|
)
|
|
|
|
with context.begin_transaction():
|
|
context.run_migrations()
|
|
|
|
|
|
def run_migrations_online() -> None:
|
|
"""Run migrations in 'online' mode.
|
|
|
|
In this scenario we need to create an Engine
|
|
and associate a connection with the context.
|
|
|
|
"""
|
|
# Check if a connection/engine is already provided (e.g., for in-memory SQLite)
|
|
# This allows tests to reuse the same in-memory database
|
|
connectable = config.attributes.get("connection", None)
|
|
|
|
if connectable is None:
|
|
# Create a new engine from config
|
|
connectable = engine_from_config(
|
|
config.get_section(config.config_ini_section, {}),
|
|
prefix="sqlalchemy.",
|
|
poolclass=pool.NullPool,
|
|
)
|
|
# We created the engine, so we should manage the connection lifecycle
|
|
with connectable.connect() as connection:
|
|
context.configure(connection=connection, target_metadata=target_metadata)
|
|
|
|
with context.begin_transaction():
|
|
context.run_migrations()
|
|
else:
|
|
# Connection was provided externally, use it but don't close it
|
|
# (the caller is responsible for cleanup)
|
|
context.configure(connection=connectable, target_metadata=target_metadata)
|
|
|
|
with context.begin_transaction():
|
|
context.run_migrations()
|
|
|
|
|
|
if context.is_offline_mode():
|
|
run_migrations_offline()
|
|
else:
|
|
run_migrations_online()
|